RFC: Rename config to config.jsonc #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json-mode supports jsonc format since 1.8.0, but does not register .jsonc as a file extension.
Only changes the name of the default config we install and does not affect the lookup logic in any way. Man pages were already fixed in Alexays#2744
Merged
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only changes the name of the default config we install and does not affect the lookup logic in any way.
Man pages were already fixed in #2744
There's already a few breaking changes queued for the next release: mandatory gtk-layer-shell, clock format changes, etc. Seems like a good point to also rename the default config to reflect that it is JSONC.