Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "empty" class for Image module when path/exec is returning an empty value. #2859

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Add "empty" class for Image module when path/exec is returning an empty value. #2859

merged 1 commit into from
Jan 23, 2024

Conversation

Sryther
Copy link
Contributor

@Sryther Sryther commented Jan 23, 2024 •
edited
Loading

If path or returned value by exec is empty, adds the .empty CSS class.

style.css:

#image {
    background-color: green;
    padding: 10px; 
}

#image.empty {
    padding: 0px;
}

results in totally hiding the module.

@Sryther Sryther marked this pull request as ready for review January 23, 2024 17:27
@Alexays
Copy link
Owner

Alexays commented Jan 23, 2024

LGTM, thx!

@Alexays Alexays merged commit 8e2fa0f into Alexays:master Jan 23, 2024
@Alexays
Copy link
Owner

Alexays commented Jan 23, 2024

Can you also update the Github wiki? :)

@Sryther
Copy link
Contributor Author

Sryther commented Jan 23, 2024

Can you also update the Github wiki? :)

Done :) ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sryther @Alexays