Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config tweaks #2969

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Config tweaks #2969

merged 2 commits into from
Feb 25, 2024

Conversation

alebastr
Copy link
Contributor

Small non-functional changes to the default configuration

"modules-right" has gotten too long, and it's easier to compare configs
that way.
Use `box-shadow` instead of borders for consistent vertical alignment.
See 77c7e10 for a similar conversion of other modules.
@zjeffer
Copy link
Contributor

zjeffer commented Feb 25, 2024

Is there a reason the default config has no extension? Adding .jsonc would make it slightly easier for editors to deduce the file type.

@Alexays
Copy link
Owner

Alexays commented Feb 25, 2024

Nope this can be renamed, waybar already lookup for config.jsonc

@Alexays Alexays merged commit 75dce1e into Alexays:master Feb 25, 2024
7 of 9 checks passed
@zjeffer
Copy link
Contributor

zjeffer commented Feb 25, 2024

No, I meant why are we putting this file in the repo without any extension?

@alebastr alebastr deleted the config-tweaks branch February 25, 2024 19:03
@alebastr
Copy link
Contributor Author

No, I meant why are we putting this file in the repo without any extension?

Because it was in the repo before .jsonc extension support. Next major release could be a good point to rename the config, both in the repo and in the installation.

For the record, that won't fix the file type detection for all editors. E.g. Emacs still needs // -*- mode: jsonc; -*- modeline.

@alebastr
Copy link
Contributor Author

#2972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants