Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make jobs prioritize processing raw data #2697

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

kurtwheeler
Copy link
Contributor

Issue Number

AlexsLemonade/refinebio-examples#455

Purpose/Implementation Notes

We found an experiment GSE99039 that has raw data but was processed using NO_OP. This is my best guess at what the issue is, but I have neither reproduced this yet nor tested this fix.

Methods

Right now we just use the first original file passed to this function. This instead only uses that if there's no original file with raw data.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

TBD

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Please attach any screenshots that illustrate these changes.

Copy link
Contributor

@davidsmejia davidsmejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kurtwheeler kurtwheeler merged commit 9c55f71 into dev Apr 5, 2021
@kurtwheeler kurtwheeler deleted the kurtwheeler/prefer-raw-files branch April 5, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants