Allow processing by project/submitter #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make run id selection more flexible
allyhawkins
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
I like this setup and it should easily be converted when we add in a unique project ID. The only other thought that I had was if we want to further segregate by disease (i.e. for projects like the Dyer group that may have a few hundred samples). But I think we could leave this as is and then when we create project ID's segregate at that point and we wouldn't have to alter this code to account for disease types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
projectparameter to the workflow that allows running all of the runs from a submitter as a block. As implemented, this option supersedes therun_idoption, which seems like what we will want most of the time, but if people think it should work differently, we could change that.I also made the
run_idoption a bit more flexible, in that it can now be used to specify library ids or sample ids as well: if any match, it will process those runs.Closes #14