-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Placeholder / Discussion] Draw a picture of what the QC report will contain for MVP #37
Comments
In an effort to get this started I went ahead and created a very very rough drawing of what I think we are looking for in the QC report. The first two tables, I also tried my best to draw out the plots but in general, I think we would have the following plots:
I also added in a section for ADT/ CITE-seq information and noticed on the issue that there was a comment to add in the list of antibodies. I wasn't sure how lengthy that could get or how we would want to portray that so I thought we might want to have that separate from the statistics? I just wanted to get a general idea of the order of things and the blocks that we need to put in place so this is pretty rough but would love to hear @jaclyn-taroni and @jashapiro thoughts/ opinions/ disagreements/ suggestions. I also wanted to keep in mind that this is for MVP so I did not choose to include any UMAPs or clustering at this point. |
This seems perfectly reasonable to me for MVP, which is to say I have no disagreements. I'm uploading a version of that sketch with lettered panels just in the interest of making the next steps easier to talk about. If @jashapiro also thinks this seems reasonable, I think the create/update issues part of this is as follows (I'm working from
Issues should have enough implementation details to get folks headed in the right direction. If we make them more specific than this sketch, which we should aim for, we can have any disagreements about details there. |
I looked into the two column thing: Looks like we can do that with "fenced divs" https://bookdown.org/yihui/rmarkdown-cookbook/multi-column.html Basically we add a bunch of WE can try it at least! |
👍🏻 new issue please :) |
I do wonder if we should combine A&C? Or move the number of cells to C? Conceptually and statistically, the number of cells after filtering and UMI/cell are related, so it seems like we might want to keep those together. |
Right now we have the following included in A:
The statistics mentioned in #18 that would be part of the table in C include median UMI/cell, median genes detected/cell, and median mito %/cell. We could append that to what we have currently in A? or We could take |
Ah, okay.. I was misunderstanding the # of cells as the number after filtering... but it is only after the barcode filtering, not emptyDrops. I think that is fine to leave in A. We should add # of cells post-emptyDrops to #18, and I will add that there. |
Agree with this, I also forgot that we included the pre empty-drops number of cells when we added that table for A to the QC report originally. Sorry about the confusion. |
I believe we can close this, as I think we have all content we expect for MVP, with maybe a new issue for "make it pretty" later? |
Yup, agreed - go for it! |
Closing for future work. |
A good way to make sure we're all on the same page about the contents and layout of the QC report is to sketch out what the overall report will look like.
From there, we can 1. disagree a little bit initially, probably 2. ensure we have issues for all the relevant sections 🚀
The text was updated successfully, but these errors were encountered: