AKU-405: Added support for form controls in tabs #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -290,12 +306,24 @@ define(["dojo/_base/declare", | |||
| // we'll ensure that the first tab is both selected and will be immediately rendered | |||
| var tabSelected = false; | |||
| array.forEach(this.widgets, function(widget) { | |||
| if (widget.delayProcessing !== false && !widget.selected) | |||
| if ((widget.delayProcessing === true && !widget.selected) || | |||
| widget.delayProcessing === false) | |||
There was a problem hiding this comment.
Could perhaps be rewritten as if (!widget.delayProcessing || !widget.selected) {
There was a problem hiding this comment.
I think I prefer this to be more explicit
MartinDoyleUK
added a commit
that referenced
this pull request
Jul 30, 2015
AKU-405: Added support for form controls in tabs
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses https://issues.alfresco.com/jira/browse/AKU-405 to add a new mixin module "alfresco/forms/LayoutMixin" that can be applied to layout controls to create layout widgets to be used inside forms. This has been abstracted and applied to the "alfresco/forms/ControlRow" widget and used to create the "alfresco/forms/TabbedControls" and "alfresco/forms/ControlColumn" modules.
Unit tests have been added to support the new modules.