ACS-7587 Implement v1 Bulk API to add items to a hold #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_implement_v1_bulk_api_to_add_items # Conflicts: # amps/ags/rm-community/rm-community-rest-api-explorer/src/main/webapp/definitions/gs-core-api.yaml
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...mmunity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkStatus.java
Fixed
Show fixed
Hide fixed
...mmunity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkStatus.java
Fixed
Show fixed
Hide fixed
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Fixed
Show fixed
Hide fixed
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Fixed
Show fixed
Hide fixed
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Fixed
Show fixed
Hide fixed
...source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/DefaultHoldBulkMonitor.java
Fixed
Show fixed
Hide fixed
...source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/DefaultHoldBulkMonitor.java
Fixed
Show fixed
Hide fixed
.../source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkStatusUpdater.java
Fixed
Show fixed
Hide fixed
...est/java/org/alfresco/module/org_alfresco_module_rm/bulk/DefaultHoldBulkMonitorUnitTest.java
Fixed
Show fixed
Hide fixed
...est/java/org/alfresco/module/org_alfresco_module_rm/bulk/DefaultHoldBulkMonitorUnitTest.java
Fixed
Show fixed
Hide fixed
damianujma
requested review from
jamalkm,
aonych,
tpage-alfresco,
dsibilio,
mikolajbrzezinski and
wojtekswieton
...y/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/alfresco-global.properties
Show resolved
Hide resolved
...mmunity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkStatus.java
Outdated
Show resolved
Hide resolved
...rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkOperationEntry.java
Outdated
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Outdated
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Outdated
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Outdated
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Outdated
Show resolved
Hide resolved
dsibilio
reviewed
May 20, 2024
...y/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/alfresco-global.properties
Outdated
Show resolved
Hide resolved
...-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkMonitor.java
Outdated
Show resolved
Hide resolved
...source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/DefaultHoldBulkMonitor.java
Outdated
Show resolved
Hide resolved
...y-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkMonitor.java
Outdated
Show resolved
Hide resolved
.../source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkStatusUpdater.java
Show resolved
Hide resolved
.../source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkStatusUpdater.java
Show resolved
Hide resolved
...munity-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkBaseService.java
Show resolved
Hide resolved
...munity-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkBaseService.java
Show resolved
Hide resolved
...munity-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkBaseService.java
Outdated
Show resolved
Hide resolved
...po/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkServiceImpl.java
Outdated
Show resolved
Hide resolved
aonych
approved these changes
May 22, 2024
mikolajbrzezinski
approved these changes
May 22, 2024
...po/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkServiceImpl.java
Fixed
Show fixed
Hide fixed
...po/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkServiceImpl.java
Fixed
Show fixed
Hide fixed
...po/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkServiceImpl.java
Fixed
Show fixed
Hide fixed
dsibilio
approved these changes
May 28, 2024
damianujma
merged commit 3cda821
into
feature/ACS-7556_bulk_update_in_legal_holds
87 checks passed
damianujma
deleted the
feature/ACS-7587_implement_v1_bulk_api_to_add_items
branch
damianujma
restored the
feature/ACS-7587_implement_v1_bulk_api_to_add_items
branch
damianujma
added a commit
that referenced
this pull request
Jun 19, 2024
* ACS-7557 Add Legal Holds Bulk v1 API (#2624) * ACS-7557 Add Legal Holds Bulk v1 API * ACS-7557 Improve v1 API * ACS-7557 Replace processId with bulkStatusId * ACS-7587 Implement v1 Bulk API to add items to a hold (#2656) * ACS-7557 Add bulk API design * ACS-7557 Fix * ACS-7557 Add permissions checks * ACS-7557 Add IT tests * ACS-7557 Add comments + logging * ACS-7557 Refactor * ACS-7557 Reimplement task container * ACS-7557 Refactor code * ACS-7587 Remove merge leftovers * ACS-7587 Refactor * ACS-7587 Tests * ACS-7587 Change DefaultHoldBulkMonitor * ACS-7587 Reimplement BulkStatusUpdater * ACS-7587 Fix PMD issues * ACS-7587 Fix PMD isues * ACS-7587 Refactor * ACS-7587 Add test files alternately * ACS-7587 Refactor code * ACS-7587 Improve search query * ACS-7587 Fix PMD issues * ACS-7587 Fix PMD issue * ACS-7587 Fix intermittent failure * ACS7587 Fix intermittent failure (#2681) * ACS-7587 Implement bulk cancellations (#2683)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following properties:
rm.hold.bulk.threadCount(default: 2) - The number of worker threads.rm.hold.bulk.maxItems(default: 1000) - The maximum number of total items to process in a single bulk operation.rm.hold.bulk.logging.interval(default: 1000) - The number of entries to process before reporting progress.rm.hold.bulk.batchSize(default: 100) - The number of entries to be fetched from the Search Service in the BatchProcessWorkProvider.getNextWork() method.rm.hold.bulk.itemsPerTransaction(default: 1) - The number of entries we process at a time in a transaction. If the umber is 1, the advantage of this is that when a transaction fails, correctly added entries are not rollbacked. If the number of the items per transaction is e.g. 100 then if one entry fails in a transaction, 99 entries are rollbacked and the BatchMonitor returns only 1 error and 99 successfully processed entries. It's worth thinking.Note: Support for the clustered environment will be added in the Enterprise Repo.