-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACS-7587 Implement bulk cancellations #2683
ACS-7587 Implement bulk cancellations #2683
Conversation
…_implement_v1_bulk_api_to_add_items # Conflicts: # amps/ags/rm-community/rm-community-rest-api-explorer/src/main/webapp/definitions/gs-core-api.yaml
…re/ACS-7587_implement_bulk_cancellation # Conflicts: # amps/ags/rm-automation/rm-automation-community-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkStatus.java # amps/ags/rm-automation/rm-automation-community-rest-api/src/main/java/org/alfresco/rest/rm/community/requests/gscore/api/HoldsAPI.java # amps/ags/rm-automation/rm-automation-community-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java # amps/ags/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/alfresco-global.properties # amps/ags/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-bulk-context.xml # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkBaseService.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkMonitor.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/DefaultHoldBulkMonitor.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkMonitor.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkProcessDetails.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkService.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkServiceImpl.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkStatusUpdater.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/holds/HoldsBulkStatusesRelation.java # amps/ags/rm-community/rm-community-repo/source/java/org/alfresco/rm/rest/api/holds/HoldsEntityResource.java # amps/ags/rm-community/rm-community-repo/unit-test/java/org/alfresco/module/org_alfresco_module_rm/bulk/DefaultHoldBulkMonitorUnitTest.java
...nity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkOperation.java
Fixed
Show fixed
Hide fixed
...nity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkOperation.java
Fixed
Show fixed
Hide fixed
...mmunity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkStatus.java
Fixed
Show fixed
Hide fixed
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Fixed
Show fixed
Hide fixed
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Fixed
Show fixed
Hide fixed
...g/alfresco/module/org_alfresco_module_rm/test/integration/bulk/hold/HoldBulkServiceTest.java
Fixed
Show fixed
Hide fixed
...g/alfresco/module/org_alfresco_module_rm/test/integration/bulk/hold/HoldBulkServiceTest.java
Fixed
Show fixed
Hide fixed
...g/alfresco/module/org_alfresco_module_rm/test/integration/bulk/hold/HoldBulkServiceTest.java
Fixed
Show fixed
Hide fixed
...g/alfresco/module/org_alfresco_module_rm/test/integration/bulk/hold/HoldBulkServiceTest.java
Fixed
Show fixed
Hide fixed
...g/alfresco/module/org_alfresco_module_rm/test/integration/bulk/hold/HoldBulkServiceTest.java
Fixed
Show fixed
Hide fixed
...nity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkOperation.java
Outdated
Show resolved
Hide resolved
...munity-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/BulkBaseService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do the bulk jobs get tidied up? Is it possible that the list will increase indefinitely and the API to list them will require a lot of paging?
@tpage-alfresco The bulk jobs get tidied up when an instance or all instances in a clustered environment are restarted because they are stored in the cache. I think tidying up is a good approach but I'm not sure what TTL cache configuration would be appropriate. |
packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/search/RestRequestQueryModel.java
Fixed
Show fixed
Hide fixed
packaging/tests/tas-restapi/src/main/java/org/alfresco/rest/search/RestRequestQueryModel.java
Fixed
Show fixed
Hide fixed
...mmunity-rest-api/src/main/java/org/alfresco/rest/rm/community/model/hold/HoldBulkStatus.java
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Show resolved
Hide resolved
...munity-rest-api/src/test/java/org/alfresco/rest/rm/community/hold/AddToHoldsBulkV1Tests.java
Outdated
Show resolved
Hide resolved
...y-repo/source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/HoldBulkService.java
Outdated
Show resolved
Hide resolved
...source/java/org/alfresco/module/org_alfresco_module_rm/bulk/hold/DefaultHoldBulkMonitor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cfda13d
into
feature/ACS-7556_bulk_update_in_legal_holds
* ACS-7557 Add Legal Holds Bulk v1 API (#2624) * ACS-7557 Add Legal Holds Bulk v1 API * ACS-7557 Improve v1 API * ACS-7557 Replace processId with bulkStatusId * ACS-7587 Implement v1 Bulk API to add items to a hold (#2656) * ACS-7557 Add bulk API design * ACS-7557 Fix * ACS-7557 Add permissions checks * ACS-7557 Add IT tests * ACS-7557 Add comments + logging * ACS-7557 Refactor * ACS-7557 Reimplement task container * ACS-7557 Refactor code * ACS-7587 Remove merge leftovers * ACS-7587 Refactor * ACS-7587 Tests * ACS-7587 Change DefaultHoldBulkMonitor * ACS-7587 Reimplement BulkStatusUpdater * ACS-7587 Fix PMD issues * ACS-7587 Fix PMD isues * ACS-7587 Refactor * ACS-7587 Add test files alternately * ACS-7587 Refactor code * ACS-7587 Improve search query * ACS-7587 Fix PMD issues * ACS-7587 Fix PMD issue * ACS-7587 Fix intermittent failure * ACS7587 Fix intermittent failure (#2681) * ACS-7587 Implement bulk cancellations (#2683)
This PR is to add the cancellation feature for the bulk operation.
POST /holds/{holdId}/bulk-statuses/{bulkStatusId}/cancel
- endpoint to cancel the bulk operationAdditionally:
FixedThreadPool
to the Bulk Service to limit the number of bulk requests we can process in parallel. By default the maximum number of parallel bulk requests is10
. That value is configurable byrm.hold.bulk.maxParallelRequests
property.