Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4168] - reset pagination on breadcrumb navigation #1816

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

VitoAlbano
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Navigating through breadcrumb won't reset pagination for DL

What is the new behaviour?
Navigating through breadcrumb will reset pagination for DL

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACA-4168

Depends on : Alfresco/alfresco-ng2-components#6375

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vito Albano seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@VitoAlbano VitoAlbano changed the title [DRAFT] [ACA-4168] - reset pagination on breadcrumb navigation [ACA-4168] - reset pagination on breadcrumb navigation Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #1816 (4f2ee6b) into develop (43cd3fd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1816      +/-   ##
===========================================
+ Coverage    67.65%   67.70%   +0.04%     
===========================================
  Files           95       95              
  Lines         2755     2756       +1     
  Branches       569      569              
===========================================
+ Hits          1864     1866       +2     
- Misses         756      757       +1     
+ Partials       135      133       -2     
Impacted Files Coverage Δ
src/app/components/files/files.component.ts 58.20% <100.00%> (+0.31%) ⬆️
...pp/components/context-menu/context-menu-overlay.ts 50.00% <0.00%> (-50.00%) ⬇️
...mponents/layout/app-layout/app-layout.component.ts 64.15% <0.00%> (+1.88%) ⬆️
...orite-library/toggle-favorite-library.component.ts 100.00% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43cd3fd...4f2ee6b. Read the comment docs.

@eromano eromano merged commit 1de6dbf into develop Nov 25, 2020
@eromano eromano deleted the dev-valbano-ACA-4168 branch November 25, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants