[ACS-3700] Pass mat menu items from external components to mat menu #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's review this for the next release, the PR addresses toolbar items, and context menu is in another component actually: |
...ects/aca-shared/src/lib/components/tool-bar/toolbar-menu-item/toolbar-menu-item.component.ts
Show resolved
Hide resolved
AleksanderSklorz
approved these changes
Oct 28, 2022
nikita-web-ua
approved these changes
Oct 31, 2022
MichalKinas
deleted the
bugfix/dev-mkinas-ACS-3700-a11y-adw-incorrect-tabbing-through-the-context-menu
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Context menu items can't be accessed via keyboard.
What is the new behaviour?
Context menu items (except ones placed with ADF DynamicExtensionComponent ) are correctly passed to the material menu which results in them being properly focused and accessible via keyboard.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: