Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOBILEAPPS-1701] Custom URL schema issues fixed #2998

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

jatin2008
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/MOBILEAPPS-1701 issues

What is the new behaviour?

  1. Not displaying dialog once user close the dialog.
  2. dialog name is localized now.
  3. dialog is now converted to floating action button and will not dismiss until the user closed it.
  4. dialog title is not scrollable now.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@jatin2008 jatin2008 changed the title Dev jatin mobileapps 1701 [MOBILEAPPS-1701] Custom URL schema issues fixed Feb 17, 2023
@DenysVuika DenysVuika merged commit 04907df into develop Feb 20, 2023
@DenysVuika DenysVuika deleted the dev-jatin-mobileapps-1701 branch February 20, 2023 15:46
@pr-triage pr-triage bot added the PR: merged label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants