[ACS-4741] User random user instead of admin in e2e #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KikoUK
approved these changes
Mar 1, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -41,25 +41,31 @@ | |||
| describe('Page titles', () => { | |||
| const loginPage = new LoginPage(); | |||
| const page = new BrowsingPage(); | |||
| const adminApi = new RepoClient(); | |||
| const username = `user-${Utils.random()}`; | |||
Check failure
Code scanning / CodeQL
Insecure randomness
eromano
approved these changes
Mar 1, 2023
DenysVuika
approved these changes
Mar 1, 2023
MichalKinas
deleted the
bugfix/dev-mkinas-ACS-4741-aca-e-2-e-change-c-280415-to-user-hruser-rather-than-admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
C280415 fails due to pagination errors. https://alfresco.atlassian.net/browse/ACS-4741
What is the new behaviour?
Test case is refactored to use random user instead of admin which fixes pagination issues.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: