Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5284] - updating a folder rule options has no effect when multiple rules exist and clicking between them #3409

Conversation

dominikiwanekhyland
Copy link
Contributor

…le rules exist and clicking between them

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
When clicking between different rules with different options (error script, running in background, influence on subfolders) sometimes no changes are visible altough the should be. Options remains usually as in the first visible rule or randomly disappear.

What is the new behaviour?
When clicking between different rules with different options everything is updated and visible as expected.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

@DominikIwanek I noticed some rendering issue with that area. If you have None for script then it is rendered fine but when you change it to something different than None then it just says:
"If errors occur run script"

Screen.Recording.2023-08-29.at.09.28.00.mov

@AleksanderSklorz
Copy link
Contributor

@DominikIwanek I noticed one more issue. Initially after refreshing "If errors occur run script" value is static, non clickable what is correct. But when you edit rule then you can click on that and select some value what should not be allowed. Also when you select some value then notice that this segment disappears

Screen.Recording.2023-08-29.at.09.30.43.mov

@dominikiwanekhyland
Copy link
Contributor Author

@AleksanderSklorz Thank you for those remarks, I have updated this PR :)

@AleksanderSklorz
Copy link
Contributor

@DominikIwanek thanks for resolving above issues. I found now new issue on your branch. Please have a look.
Basically when you have not selected "Run rule in the background" then you can still open dropdown although it is invisible.

Screen.Recording.2023-08-30.at.08.42.34.mov

@dominikiwanekhyland dominikiwanekhyland merged commit 303a862 into develop Aug 30, 2023
26 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the ACS-5284-updating-a-rule-that-does-not-have-run-rule-in-background-option-checked-to-then-include-it-removes-the-rule-options-in-the-manage-rules-screen branch August 30, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants