[ACS-8453] Fixed alignment issue of reduce panel button in expanded file details #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
approved these changes
Jul 25, 2024
DenysVuika
reviewed
Jul 25, 2024
| @@ -3,6 +3,7 @@ app-details-manager { | |||
| display: flex; | |||
|
|
|||
| .aca-close-details-button { | |||
| display: flex; | |||
There was a problem hiding this comment.
the parent container is already flex, can you maybe remove the "margin-right" and "margin-top" and use "gap" (or column/row-gap) instead?
There was a problem hiding this comment.
I tried to do that, but the sibling element to the close button is not another button/simple HTML element, but rather the aca-toolbar component. So just adding the gap properties did not have any effect, and we might have to start modifying the styles of the toolbar component as well, which will have a very high impact, since its being used extensively throughout the application
dominikiwanekhyland
approved these changes
Jul 25, 2024
swapnil-verma-gl
force-pushed
the
dev-acs-8453-expand-details-btn-align
branch
from
1c7d17a
to
9536f24
Compare
|
g-jaskowski
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Reduce panel details button was not aligned properly after ng15 upgrade
What is the new behaviour?
Fixed alignment of button
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://hyland.atlassian.net/browse/ACS-8453