Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix #653 #663

Merged
merged 6 commits into from Sep 24, 2018
Merged

Typo fix #653 #663

merged 6 commits into from Sep 24, 2018

Conversation

sergiuv2020
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application / Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The current sed doesn't do the replacement properly.

What is the new behavior?

Typo fix.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@sergiuv2020 sergiuv2020 changed the base branch from master to development September 24, 2018 08:03
@DenysVuika
Copy link
Contributor

Has a conflict, might need rebase

@codecov-io
Copy link

Codecov Report

Merging #663 into development will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #663      +/-   ##
===============================================
+ Coverage        67.53%   67.67%   +0.13%     
===============================================
  Files               47       47              
  Lines             2190     2187       -3     
  Branches           397      398       +1     
===============================================
+ Hits              1479     1480       +1     
+ Misses             649      645       -4     
  Partials            62       62
Impacted Files Coverage Δ
src/app/extensions/extension.service.ts 62% <0%> (-0.5%) ⬇️
src/app/services/profile.resolver.ts 20% <0%> (ø) ⬆️
src/app/testing/app-testing.module.ts 33.33% <0%> (ø) ⬆️
src/app/services/node-permission.service.ts 96.87% <0%> (ø) ⬆️
src/app/services/content-api.service.ts 32.78% <0%> (ø) ⬆️
src/app/services/node-actions.service.ts 85.71% <0%> (ø) ⬆️
src/app/services/content-management.service.ts 69.85% <0%> (ø) ⬆️
.../search/search-results/search-results.component.ts 19.71% <0%> (+0.27%) ⬆️
src/app/store/actions/app.actions.ts 65.71% <0%> (+0.71%) ⬆️
src/app/components/layout/layout.component.ts 88% <0%> (+4.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e7a3dd...020a93f. Read the comment docs.

@sergiuv2020
Copy link
Contributor Author

Fixed the conflict.

@DenysVuika DenysVuika merged commit 912dab6 into development Sep 24, 2018
@DenysVuika DenysVuika deleted the svidrascu-fix-#653 branch September 24, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants