Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

don't copy ts files to dist/package/src #1110

Closed
wants to merge 1 commit into from

Conversation

garth
Copy link

@garth garth commented May 18, 2021

fixes #1083

Please check if the PR fulfills these requirements

[ ] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eromano
Copy link
Contributor

eromano commented May 19, 2021

I don't think is needed because src is in the npmignore

@garth
Copy link
Author

garth commented May 19, 2021

With beta 30 installed via npm the src ts files are still there.

Also consider that when using yarn link it's not enough to .npmignore, you need a working dist folder.

@eromano
Copy link
Contributor

eromano commented May 20, 2021

with npm works, yes probably in link scenario nope

@eromano
Copy link
Contributor

eromano commented May 20, 2021

good point

@eromano
Copy link
Contributor

eromano commented May 24, 2021

#1113 moved here in order to let the CI run

@eromano eromano closed this May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PR #1081 does not fully fix type errors
3 participants