This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
add "browser" target to fix bundling issues #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows using both within node.js and browser environments by specifying "browser" target that can be used for bundlers, like Webpack: https://webpack.js.org/configuration/resolve/#resolve-mainfields
Codecov Report
@@ Coverage Diff @@
## development #190 +/- ##
============================================
Coverage 91.03% 91.03%
============================================
Files 10 10
Lines 524 524
Branches 68 68
============================================
Hits 477 477
Misses 47 47Continue to review full report at Codecov.
|
DenysVuika
pushed a commit
that referenced
this pull request
Mar 6, 2017
* add "browser" target to fix bundling issues (#190) Allows using both within node.js and browser environments by specifying "browser" target that can be used for bundlers, like Webpack: https://webpack.js.org/configuration/resolve/#resolve-mainfields * Update CHANGELOG.md * #187 Fix getContentThumbnailUrl using the enterprise path (#188) * 1.2.1 * build 1.2.1 * Update CHANGELOG.md
magemello
added a commit
that referenced
this pull request
Mar 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using both within node.js and browser environments by specifying "browser" target that can be used for bundlers, like Webpack: https://webpack.js.org/configuration/resolve/#resolve-mainfields
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: