Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

#187 Fix getContentThumbnailUrl using the enterprise path #188

Merged
merged 2 commits into from
Mar 6, 2017

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

[ ] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-ap/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
#187

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.051% when pulling 3d744ad on dev-mvitale-1871 into d15eba1 on development.

@codecov-io
Copy link

codecov-io commented Mar 3, 2017

Codecov Report

Merging #188 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #188   +/-   ##
============================================
  Coverage        91.03%   91.03%           
============================================
  Files               10       10           
  Lines              524      524           
  Branches            68       68           
============================================
  Hits               477      477           
  Misses              47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d07333...6d559c0. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.051% when pulling 6d559c0 on dev-mvitale-1871 into 8d07333 on development.

@magemello magemello merged commit b75e00a into development Mar 6, 2017
DenysVuika pushed a commit that referenced this pull request Mar 6, 2017
* add "browser" target to fix bundling issues (#190)

Allows using both within node.js and browser environments by specifying "browser" target that can be used for bundlers, like Webpack: https://webpack.js.org/configuration/resolve/#resolve-mainfields

* Update CHANGELOG.md

* #187 Fix getContentThumbnailUrl using the enterprise path (#188)

* 1.2.1

* build 1.2.1

* Update CHANGELOG.md
@DenysVuika DenysVuika deleted the dev-mvitale-1871 branch June 19, 2017 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants