* Fixed failing unit tests

Alfresco · May 26, 2020 · 0d40b1e · 0d40b1e
1 parent 5d134b4
commit 0d40b1e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/demo-shell/src/app/components/process-service/process-service.component.html b/demo-shell/src/app/components/process-service/process-service.component.html
@@ -222,7 +222,6 @@
                         [showSelectApplicationDropdown]="showApplications"
                         [title]="'ADF_PROCESS_LIST.START_PROCESS.FORM.TITLE'"
                         [name]="defaultProcessName"
-
                         (formContentClicked)="onContentClick($event)"
                         (start)="onStartProcessInstance($event)"
                         (cancel)="onCancelProcessInstance()">

diff --git a/demo-shell/src/app/components/process-service/process-service.component.ts b/demo-shell/src/app/components/process-service/process-service.component.ts
@@ -179,7 +179,7 @@ export class ProcessServiceComponent implements AfterViewInit, OnDestroy, OnInit
         this.defaultProcessName = this.appConfig.get<string>('adf-start-process.name');
         this.defaultProcessDefinitionName = this.appConfig.get<string>('adf-start-process.processDefinitionName');
         this.defaultTaskName = this.appConfig.get<string>('adf-start-task.name');
-
+        this.processDefinitionName = this.defaultProcessDefinitionName;
         // Uncomment this line to replace all 'text' field editors with custom component
         // formRenderingService.setComponentTypeResolver('text', () => CustomEditorComponent, true);
 

diff --git a/lib/process-services/src/lib/form/start-form.component.spec.ts b/lib/process-services/src/lib/form/start-form.component.spec.ts
@@ -88,7 +88,7 @@ describe('StartFormComponent', () => {
     });
 
     it('should not load start form when changes notified but no change to processDefinitionId', () => {
-        component.processDefinitionId = exampleId1;
+        component.processDefinitionId = undefined;
         component.ngOnChanges({ otherProp: new SimpleChange(exampleId1, exampleId2, true) });
         expect(formService.getStartFormDefinition).not.toHaveBeenCalled();
     });

diff --git a/lib/process-services/src/lib/process-list/components/start-process.component.spec.ts b/lib/process-services/src/lib/process-list/components/start-process.component.spec.ts
@@ -602,13 +602,13 @@ describe('StartFormComponent', () => {
             fixture.detectChanges();
             component.name = 'My new process';
             component.showSelectApplicationDropdown = true;
-            const change = new SimpleChange(null, 3, true);
             getDefinitionsSpy.and.returnValue(of(testMultipleProcessDefs));
             getDeployedApplicationsSpy = spyOn(appsProcessService, 'getDeployedApplications').and.returnValue(of(deployedApps));
-            component.ngOnChanges({ 'appId': change });
         });
 
         it('Should be able to show application drop-down and respective process definitions if showSelectApplicationDropdown set to true', () => {
+            const change = new SimpleChange(null, 3, true);
+            component.ngOnChanges({ 'appId': change });
             fixture.detectChanges();
             const appsSelector = fixture.nativeElement.querySelector('[data-automation-id="adf-start-process-apps-drop-down"]');
             const lableElement = fixture.nativeElement.querySelector('.adf-start-process-app-list .mat-form-field-label');
@@ -617,7 +617,7 @@ describe('StartFormComponent', () => {
             expect(lableElement.innerText).toEqual('ADF_PROCESS_LIST.START_PROCESS.FORM.LABEL.SELECT_APPLICATION');
 
             expect(getDeployedApplicationsSpy).toHaveBeenCalled();
-            expect(component.applications.length).toBe(6);
+            expect(component.applications.length).toBe(7);
 
             expect(component.selectedApplication).toEqual(deployedApps[2]);
             expect(component.selectedApplication.id).toEqual(component.appId);
@@ -630,6 +630,8 @@ describe('StartFormComponent', () => {
         });
 
         it('Should be able to list process-definition based on selected application', () => {
+            const change = new SimpleChange(null, 3, true);
+            component.ngOnChanges({ 'appId': change });
             fixture.detectChanges();
             expect(component.appId).toBe(component.selectedApplication.id);
             expect(component.selectedApplication).toEqual(deployedApps[2]);
@@ -656,25 +658,23 @@ describe('StartFormComponent', () => {
             expect(component.processDefinitions[0].name).toEqual('My Process 3');
         });
 
-        it('Should be able to select first application from the apps as default application when appId is not defined', () => {
-            component.appId = undefined;
-            const change = new SimpleChange(null, undefined, true);
+        it('Should be able to show all option as default when defined appId is not exists', () => {
+            const change = new SimpleChange(null, 123, true);
             component.ngOnChanges({ 'appId': change });
             fixture.detectChanges();
             expect(getDeployedApplicationsSpy).toHaveBeenCalled();
-            expect(component.applications.length).toEqual(6);
-            expect(component.selectedApplication).toEqual(deployedApps[0]);
-            expect(component.selectedApplication.name).toEqual('App1');
+            expect(component.applications.length).toEqual(7);
+            expect(component.selectedApplication.name).toEqual('All');
         });
 
-        it('Should be able to select first application from the apps as default application when given appId does not exits', () => {
-            component.appId = 123;
-            const change = new SimpleChange(null, 123, true);
+        it('Should be able to select an application from the apps as default application when given appId is defined', () => {
+            component.appId = 1;
+            const change = new SimpleChange(null, 1, true);
             component.ngOnChanges({ 'appId': change });
             fixture.detectChanges();
             expect(getDeployedApplicationsSpy).toHaveBeenCalled();
-            expect(component.applications.length).toEqual(6);
-            expect(component.selectedApplication.id).not.toEqual(component.appId);
+            expect(component.applications.length).toEqual(7);
+            expect(component.selectedApplication.id).toEqual(component.appId);
             expect(component.selectedApplication.id).toEqual(1);
             expect(component.selectedApplication.name).toEqual('App1');
         });