Skip to content

Commit

Permalink
* Removed xpath locator
Browse files Browse the repository at this point in the history
  • Loading branch information
sivakumar414ram committed May 5, 2020
1 parent 17da6cd commit 3ccf4fe
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion e2e/pages/adf/process-services/process-filters.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class ProcessFiltersPage {
rows: Locator = by.css('adf-process-instance-list div[class="adf-datatable-body"] adf-datatable-row[class*="adf-datatable-row"]');
tableBody: ElementFinder = element.all(by.css('adf-datatable div[class="adf-datatable-body"]')).first();
nameColumn: Locator = by.css('div[class*="adf-datatable-body"] adf-datatable-row[class*="adf-datatable-row"] div[title="Name"] span');
processIcon: ElementFinder = element(by.css('adf-icon[data-automation-id="adf-filter-icon"]'));
processIcon = by.css('adf-icon[data-automation-id="adf-filter-icon"]');

async startProcess(): Promise<StartProcessPage> {
await this.clickCreateProcessButton();
Expand Down
4 changes: 2 additions & 2 deletions e2e/pages/adf/process-services/task-filters.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
* limitations under the License.
*/

import { by, element, ElementFinder } from 'protractor';
import { by, ElementFinder } from 'protractor';
import { BrowserVisibility, BrowserActions } from '@alfresco/adf-testing';

export class TaskFiltersPage {

filter;
taskIcon: ElementFinder = element(by.css('adf-icon[data-automation-id="adf-filter-icon"]'));
taskIcon = by.css('adf-icon[data-automation-id="adf-filter-icon"]');

constructor(filter: ElementFinder) {
this.filter = filter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { BrowserActions } from '../../core/utils/browser-actions';
export class ProcessFiltersCloudComponentPage {

filter: ElementFinder;
filterIcon: ElementFinder = element(by.css('.adf-icon'));
filterIcon = by.css('adf-icon[data-automation-id="adf-filter-icon"]');

processFilters: ElementFinder = element(by.css("mat-expansion-panel[data-automation-id='Process Filters']"));

Expand Down
2 changes: 1 addition & 1 deletion lib/testing/src/lib/process-services/pages/filters.page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class FiltersPage {

accordionMenu: ElementFinder = element(by.css('.app-processes-menu mat-accordion'));
buttonWindow: ElementFinder = element(by.css('div > button[data-automation-id="btn-start-process"] > div'));
processIcon: ElementFinder = element(by.css('adf-icon[data-automation-id="adf-filter-icon"]'));
processIcon = by.css('adf-icon[data-automation-id="adf-filter-icon"]');

async clickFilterButton(filterElement: ElementFinder): Promise<void> {
await BrowserActions.click(filterElement);
Expand Down

0 comments on commit 3ccf4fe

Please sign in to comment.