ACS-8254 add unit test

Alfresco · Jun 21, 2024 · 591489a · 591489a
1 parent 2907b4a
commit 591489a
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/lib/core/src/lib/dialogs/dialog/dialog.component.spec.ts b/lib/core/src/lib/dialogs/dialog/dialog.component.spec.ts
@@ -23,6 +23,7 @@ import { DialogData } from './dialog-data.interface';
 import { DialogSize } from './dialog.model';
 import { CoreTestingModule } from '../../testing';
 import { Component, DebugElement, inject } from '@angular/core';
+import { Subject } from 'rxjs';
 
 @Component({
     selector: 'adf-dummy-component'
@@ -38,6 +39,8 @@ describe('DialogComponent', () => {
     let cancelButton: HTMLButtonElement;
     let confirmButton: HTMLButtonElement;
     let dialogContainer: HTMLElement;
+    const mockId = 'mockId';
+    const mockDataOnConfirm$ = new Subject();
 
     const data: DialogData = {
         title: 'Title',
@@ -96,7 +99,7 @@ describe('DialogComponent', () => {
     describe('confirm action', () => {
         const mockButtonTitle = 'mockTitle';
         beforeEach(() => {
-            setupBeforeEach({ ...data, confirmButtonTitle: mockButtonTitle });
+            setupBeforeEach({ ...data, confirmButtonTitle: mockButtonTitle, dataOnConfirm$: mockDataOnConfirm$ });
             fixture.detectChanges();
         });
 
@@ -124,11 +127,19 @@ describe('DialogComponent', () => {
             expect(confirmButton.getAttribute('disabled')).toBeTruthy();
         });
 
-        it('should close dialog', () => {
+        it('should close dialog and pass default value', () => {
             component.onConfirm();
             expect(dialogRef.close).toHaveBeenCalledWith(true);
         });
 
+        it('should close dialog and pass dataOnConfirm$', () => {
+            mockDataOnConfirm$.next(mockId);
+
+            component.onConfirm();
+
+            expect(dialogRef.close).toHaveBeenCalledWith(mockId);
+        });
+
         it('should set correct button title', () => {
             expect(component.confirmButtonTitle).toEqual(mockButtonTitle);
         });

diff --git a/lib/core/src/lib/dialogs/dialog/dialog.component.ts b/lib/core/src/lib/dialogs/dialog/dialog.component.ts
@@ -43,6 +43,7 @@ export class DialogComponent implements OnDestroy {
     cancelButtonTitle: string;
     dialogSize: DialogSizes;
     additionalActionButtons: AdditionalDialogActionButton[];
+    dataOnConfirm: any;
 
     dataInjector: Injector;
 
@@ -68,12 +69,16 @@ export class DialogComponent implements OnDestroy {
             if (data.isConfirmButtonDisabled$) {
                 data.isConfirmButtonDisabled$.pipe(takeUntil(this.onDestroy$)).subscribe((value) => this.isConfirmButtonDisabled$.next(value));
             }
+
+            if (data.dataOnConfirm$) {
+                data.dataOnConfirm$.pipe(takeUntil(this.onDestroy$)).subscribe((value) => (this.dataOnConfirm = value));
+            }
         }
     }
 
     onConfirm() {
         this.isConfirmButtonDisabled$.next(true);
-        this.dialogRef.close(this.data.dataOnConfirm$ || true);
+        this.dialogRef.close(this.dataOnConfirm || true);
     }
 
     ngOnDestroy() {