Skip to content

Commit

Permalink
[ACA-3613] Inconsistent role value between library views (#5855)
Browse files Browse the repository at this point in the history
* [ACA-3613] Inconsistent role value between library views

* [ACA-3670] Inconsistent empty role value between library views

* fixed ut
  • Loading branch information
dhrn committed Jul 14, 2020
1 parent 81d3247 commit 8ac683d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
Expand Up @@ -22,7 +22,7 @@ import { NO_ERRORS_SCHEMA, CUSTOM_ELEMENTS_SCHEMA } from '@angular/core';
import { ContentTestingModule } from '../../../testing/content.testing.module';
import { TranslateModule } from '@ngx-translate/core';

describe('LibraryNameColumnComponent', () => {
describe('LibraryRoleColumnComponent', () => {
let fixture: ComponentFixture<LibraryRoleColumnComponent>;
let component: LibraryRoleColumnComponent;

Expand Down Expand Up @@ -96,6 +96,6 @@ describe('LibraryNameColumnComponent', () => {
component.displayText$.subscribe((val) => value = val);

fixture.detectChanges();
expect(value).toBe('');
expect(value).toBe('LIBRARY.ROLE.NONE');
});
});
Expand Up @@ -86,7 +86,7 @@ export class LibraryRoleColumnComponent implements OnInit, OnDestroy {
this.displayText$.next('LIBRARY.ROLE.CONSUMER');
break;
default:
this.displayText$.next('');
this.displayText$.next('LIBRARY.ROLE.NONE');
break;
}
}
Expand Down
3 changes: 2 additions & 1 deletion lib/content-services/src/lib/i18n/en.json
Expand Up @@ -401,7 +401,8 @@
"MANAGER": "Manager",
"COLLABORATOR": "Collaborator",
"CONTRIBUTOR": "Contributor",
"CONSUMER": "Consumer"
"CONSUMER": "Consumer",
"NONE": "Not a member"
},
"VISIBILITY": {
"PRIVATE": "Private",
Expand Down

0 comments on commit 8ac683d

Please sign in to comment.