Skip to content

Commit

Permalink
[AAE-6087] Update base card view item with optional hint parameter (#…
Browse files Browse the repository at this point in the history
…7285)

* [AAE-6087] Update base card view item with optional hint parameter

* fix typo
  • Loading branch information
popovicsandras committed Oct 7, 2021
1 parent 09a2aab commit 8e9bf9c
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export interface CardViewItemProperties {
editable?: boolean;
clickable?: any;
icon?: string;
hint?: string;
validators?: CardViewItemValidator[];
data?: any;
constraints?: Constraint[];
Expand Down
26 changes: 26 additions & 0 deletions lib/core/card-view/models/card-view-baseitem.model.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,32 @@ describe('CardViewBaseItemModel', () => {

expect(itemModel.data).toBe(properties.data);
});

it('should persist the params\' properties as own properties', () => {
const allProperties = {
...properties,
default: 'default-value',
editable: true,
clickable: true,
icon: 'dummy-icon',
hint: 'Some hint text',
validators: [{} as unknown as CardViewItemValidator],
multivalued: true
};

const itemModel = new CarViewCustomItemModel(allProperties);

expect(itemModel.label).toBe(allProperties.label);
expect(itemModel.value).toBe(allProperties.value);
expect(itemModel.key).toBe(allProperties.key);
expect(itemModel.default).toBe(allProperties.default);
expect(itemModel.editable).toBe(allProperties.editable);
expect(itemModel.clickable).toBe(allProperties.clickable);
expect(itemModel.icon).toBe(allProperties.icon);
expect(itemModel.hint).toBe(allProperties.hint);
expect(itemModel.validators).toBe(allProperties.validators);
expect(itemModel.multivalued).toBe(allProperties.multivalued);
});
});

describe('isValid & Validation errors', () => {
Expand Down
2 changes: 2 additions & 0 deletions lib/core/card-view/models/card-view-baseitem.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export abstract class CardViewBaseItemModel {
editable: boolean;
clickable: boolean;
icon?: string;
hint?: string;
validators?: CardViewItemValidator[];
data?: any;
type?: string;
Expand All @@ -39,6 +40,7 @@ export abstract class CardViewBaseItemModel {
this.editable = !!cardViewItemProperties.editable;
this.clickable = !!cardViewItemProperties.clickable;
this.icon = cardViewItemProperties.icon || '';
this.hint = cardViewItemProperties.hint || '';
this.validators = cardViewItemProperties.validators || [];
this.data = cardViewItemProperties.data || null;
this.multivalued = !!cardViewItemProperties.multivalued;
Expand Down

0 comments on commit 8e9bf9c

Please sign in to comment.