Skip to content

Commit

Permalink
* Fixed lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
@sivakumar414ram
sivakumar414ram committed Apr 28, 2021
1 parent 8643ad3 commit 9439f35
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 20 deletions.
22 changes: 11 additions & 11 deletions lib/process-services/src/lib/task-list/components/task-filters.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ describe('TaskFiltersComponent', () => {

it('Should call the API to create the default task filters when no task filters exist', async () => {
spyOn(taskFilterService, 'getTaskListFilters').and.returnValue(of([]));
const filtersMock = [{ name: 'dafult-task-filter-1'}, { name: 'dafult-task-filter-2'}];
const filtersMock = [{ name: 'default-task-filter-1'}, { name: 'default-task-filter-2'}];
const createDefaultFiltersSpy = spyOn(taskFilterService, 'createDefaultFilters').and.returnValue(of(filtersMock));
const appId = '2';
const change = new SimpleChange(null, appId, true);
Expand Down Expand Up @@ -369,24 +369,24 @@ describe('TaskFiltersComponent', () => {
it('Should be able to display default task filters', async () => {
spyOn(taskFilterService, 'getTaskListFilters').and.returnValue(of([]));
const defaultTaskFiltersMock = [
{ name: 'dafult-my-filter' },
{ name: 'dafult-involved-filter' },
{ name: 'dafult-completed-filter' },
]
{ name: 'default-my-filter' },
{ name: 'default-involved-filter' },
{ name: 'default-completed-filter' }
];
spyOn(taskFilterService, 'createDefaultFilters').and.returnValue(of(defaultTaskFiltersMock));
const appId = '2';
const change = new SimpleChange(null, appId, true);
component.ngOnChanges({ 'appId': change });

fixture.detectChanges();

const taskFilterOne = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="dafult-my-filter_filter"]`);
const taskFilterTwo = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="dafult-involved-filter_filter"]`);
const taskFilterThree = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="dafult-completed-filter_filter"]`);
const taskFilterOne = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="default-my-filter_filter"]`);
const taskFilterTwo = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="default-involved-filter_filter"]`);
const taskFilterThree = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="default-completed-filter_filter"]`);

expect(taskFilterOne.innerText).toBe('dafult-my-filter');
expect(taskFilterTwo.innerText).toBe('dafult-involved-filter');
expect(taskFilterThree.innerText).toBe('dafult-completed-filter');
expect(taskFilterOne.innerText).toBe('default-my-filter');
expect(taskFilterTwo.innerText).toBe('default-involved-filter');
expect(taskFilterThree.innerText).toBe('default-completed-filter');
});
});
});
13 changes: 4 additions & 9 deletions lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -857,12 +857,11 @@ describe('TaskFormComponent', () => {

describe('Task form action buttons', () => {

it('Task form action status when candidate user is not have a access to the task claimed by another candidate user', async() => {
it('Should disable Complete button when candidate user is not have a access to the task claimed by another candidate user', async() => {
getTaskDetailsSpy.and.returnValue(of(involvedUserTaskForm));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const saveButton = fixture.debugElement.nativeElement.querySelector('[id="adf-form-save"]');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-form-complete');
Expand All @@ -882,7 +881,6 @@ describe('TaskFormComponent', () => {
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const saveButton = fixture.debugElement.nativeElement.querySelector('[id="adf-form-save"]');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-form-complete');
Expand All @@ -904,7 +902,6 @@ describe('TaskFormComponent', () => {
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const saveButton = fixture.debugElement.nativeElement.querySelector('[id="adf-form-save"]');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-form-complete');
Expand All @@ -921,12 +918,11 @@ describe('TaskFormComponent', () => {
});

it('Should show only the Claim button as enabled before claiming a task without form', async() => {
const claimableTaskDetailsWithoutFormMock = { ...claimableTaskDetailsMock, formKey: null }
const claimableTaskDetailsWithoutFormMock = { ...claimableTaskDetailsMock, formKey: null };
getTaskDetailsSpy.and.returnValue(of(claimableTaskDetailsWithoutFormMock));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const cancelButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-cancel-button');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-complete-button');
Expand All @@ -942,13 +938,12 @@ describe('TaskFormComponent', () => {
});

it('Should show only Complete/Release buttons as enabled after claiming a task without form', async() => {
const claimedTaskDetailsWithoutFormMock = { ...claimedTaskDetailsMock, formKey: null }
const claimedTaskDetailsWithoutFormMock = { ...claimedTaskDetailsMock, formKey: null };
getBpmLoggedUserSpy.and.returnValue(of(claimedTaskDetailsWithoutFormMock.assignee));
getTaskDetailsSpy.and.returnValue(of(claimedTaskDetailsWithoutFormMock));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const cancelButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-cancel-button');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-complete-button');
Expand All @@ -962,5 +957,5 @@ describe('TaskFormComponent', () => {
expect(releaseButton.nativeElement.disabled).toBe(false, 'Release button is disabled');
expect(claimButton).toBeNull();
});
})
});
});

0 comments on commit 9439f35

Please sign in to comment.