Skip to content

Commit

Permalink
[ACA-4389] [APS1] Convert some of process services extension E2E step…
Browse files Browse the repository at this point in the history 
…s to unit-tests (#6959)

* [ACA-4389] [APS1] make sure to move/convert some of E2E steps to unit-tests

* * Added fail test description

* * Fixed comments

* * Fixed lint errors
  • Loading branch information
@sivakumar414ram
sivakumar414ram committed May 4, 2021
1 parent 184b203 commit b77e037
Show file tree
Hide file tree
Showing 2 changed files with 229 additions and 1 deletion.
38 changes: 38 additions & 0 deletions lib/process-services/src/lib/task-list/components/task-filters.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,18 @@ describe('TaskFiltersComponent', () => {
component.ngOnInit();
});

it('Should call the API to create the default task filters when no task filters exist', async () => {
spyOn(taskFilterService, 'getTaskListFilters').and.returnValue(of([]));
const filtersMock = [{ name: 'default-task-filter-1'}, { name: 'default-task-filter-2'}];
const createDefaultFiltersSpy = spyOn(taskFilterService, 'createDefaultFilters').and.returnValue(of(filtersMock));
const appId = '2';
const change = new SimpleChange(null, appId, true);
component.ngOnChanges({ 'appId': change });
fixture.detectChanges();

expect(createDefaultFiltersSpy).toHaveBeenCalledWith(appId);
});

it('should return the filter task list, filtered By Name', (done) => {

const fakeDeployedApplicationsPromise = new Promise(function (resolve) {
Expand Down Expand Up @@ -351,4 +363,30 @@ describe('TaskFiltersComponent', () => {
await fixture.whenStable();
expect(component.currentFilter).toBe(undefined);
});

describe('Display Task Filters', () => {

it('Should be able to display default task filters', async () => {
spyOn(taskFilterService, 'getTaskListFilters').and.returnValue(of([]));
const defaultTaskFiltersMock = [
{ name: 'default-my-filter' },
{ name: 'default-involved-filter' },
{ name: 'default-completed-filter' }
];
spyOn(taskFilterService, 'createDefaultFilters').and.returnValue(of(defaultTaskFiltersMock));
const appId = '2';
const change = new SimpleChange(null, appId, true);
component.ngOnChanges({ 'appId': change });

fixture.detectChanges();

const taskFilterOne = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="default-my-filter_filter"]`);
const taskFilterTwo = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="default-involved-filter_filter"]`);
const taskFilterThree = fixture.debugElement.nativeElement.querySelector(`[data-automation-id="default-completed-filter_filter"]`);

expect(taskFilterOne.innerText).toBe('default-my-filter');
expect(taskFilterTwo.innerText).toBe('default-involved-filter');
expect(taskFilterThree.innerText).toBe('default-completed-filter');
});
});
});
192 changes: 191 additions & 1 deletion lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ import {
initiatorWithCandidatesTaskDetailsMock,
involvedUserTaskForm,
fakeUser,
involvedGroupTaskForm
involvedGroupTaskForm,
completedTaskWithFormMock
} from '../../../mock/task/task-details.mock';
import { TaskDetailsModel } from '../../models/task-details.model';
import { ProcessTestingModule } from '../../../testing/process.testing.module';
Expand Down Expand Up @@ -768,4 +769,193 @@ describe('TaskFormComponent', () => {
expect(completeButton.disabled).toEqual(true);
});
});

describe('Task Form Fields Visibility', () => {

it('Should task form fields be disabled when the form is readonly', async () => {
fixture.detectChanges();
getTaskDetailsSpy.and.returnValue(of(taskDetailsMock));
component.taskId = '456';
component.readOnlyForm = true;
component.ngOnInit();

fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const activitFormSelector = element.querySelector('adf-form');
const inputFieldOne = fixture.debugElement.nativeElement.querySelector('#text1');
const inputFieldTwo = fixture.debugElement.nativeElement.querySelector('#text2');
const inputFieldThree = fixture.debugElement.nativeElement.querySelector('#text3');
expect(activitFormSelector).toBeDefined();
expect(inputFieldOne['disabled']).toEqual(true, 'Task Form field is enabled');
expect(inputFieldTwo['disabled']).toEqual(true, 'Task Form field is enabled');
expect(inputFieldThree['disabled']).toEqual(true, 'Task Form field is enabled');
});

it('Should task form fields be disabled when the task has not been claimed', async () => {
fixture.detectChanges();
getTaskDetailsSpy.and.returnValue(of(claimableTaskDetailsMock));
component.taskId = '456';
component.ngOnInit();

fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const activitFormSelector = element.querySelector('adf-form');
const inputFieldOne = fixture.debugElement.nativeElement.querySelector('#text1');
const inputFieldTwo = fixture.debugElement.nativeElement.querySelector('#text2');
const inputFieldThree = fixture.debugElement.nativeElement.querySelector('#text3');
expect(activitFormSelector).toBeDefined();
expect(inputFieldOne['disabled']).toEqual(true, 'Task Form field is enabled');
expect(inputFieldTwo['disabled']).toEqual(true, 'Task Form field is enabled');
expect(inputFieldThree['disabled']).toEqual(true, 'Task Form field is enabled');
});

it('Should task form fields be disabled when the task is completed', async () => {
fixture.detectChanges();
getTaskDetailsSpy.and.returnValue(of(completedTaskWithFormMock));
component.taskId = '456';
component.ngOnInit();
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const activitFormSelector = element.querySelector('adf-form');
const inputFieldOne = fixture.debugElement.nativeElement.querySelector('#text1');
const inputFieldTwo = fixture.debugElement.nativeElement.querySelector('#text2');
const inputFieldThree = fixture.debugElement.nativeElement.querySelector('#text3');

expect(activitFormSelector).toBeDefined();
expect(inputFieldOne['disabled']).toEqual(true);
expect(inputFieldTwo['disabled']).toEqual(true);
expect(inputFieldThree['disabled']).toEqual(true);
});

it('Should task form fields be enabled when the task is claimed', async() => {
fixture.detectChanges();
getBpmLoggedUserSpy.and.returnValue(of(claimedTaskDetailsMock.assignee));
getTaskDetailsSpy.and.returnValue(of(claimedTaskDetailsMock));
component.taskId = '456';
component.ngOnInit();
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();

const activitFormSelector = element.querySelector('adf-form');
const inputFieldOne = fixture.debugElement.nativeElement.querySelector('#text1');
const inputFieldTwo = fixture.debugElement.nativeElement.querySelector('#text2');
const inputFieldThree = fixture.debugElement.nativeElement.querySelector('#text3');

expect(activitFormSelector).toBeDefined();
expect(inputFieldOne['disabled']).toEqual(false, 'Task Form field is disabled');
expect(inputFieldTwo['disabled']).toEqual(false, 'Task Form field is disabled');
expect(inputFieldThree['disabled']).toEqual(false, 'Task Form field is disabled');
});
});

describe('Task form action buttons', () => {

it('Should disable Complete button when candidate user is not have a access to the task claimed by another candidate user', async() => {
getTaskDetailsSpy.and.returnValue(of(involvedUserTaskForm));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();

const saveButton = fixture.debugElement.nativeElement.querySelector('[id="adf-form-save"]');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-form-complete');
const claimButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-claim-button"]'));
const releaseButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-unclaim-button"]'));

expect(saveButton).not.toBeNull();
expect(saveButton['disabled']).toBe(false, 'Save button is disabled');
expect(completeButton).not.toBeNull();
expect(completeButton['disabled']).toBe(true, 'Complete button is disabled');
expect(claimButton).toBeNull();
expect(releaseButton).toBeNull();
});

it('Should show only the Claim button as enabled before claiming a task with form', async() => {
getTaskDetailsSpy.and.returnValue(of(claimableTaskDetailsMock));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();

const saveButton = fixture.debugElement.nativeElement.querySelector('[id="adf-form-save"]');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-form-complete');
const claimButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-claim-button"]'));
const releaseButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-unclaim-button"]'));

expect(saveButton).not.toBeNull();
expect(saveButton['disabled']).toBe(true, 'Save button is enabled');
expect(completeButton).not.toBeNull();
expect(completeButton['disabled']).toBe(true, 'Complete button is enabled');
expect(claimButton).not.toBeNull();
expect(claimButton.nativeElement.disabled).toBe(false, 'Claim button is disabled');
expect(releaseButton).toBeNull();
});

it('Should show only Save/Complete/Release buttons as enabled after claiming a task with form', async() => {
getBpmLoggedUserSpy.and.returnValue(of(claimedTaskDetailsMock.assignee));
getTaskDetailsSpy.and.returnValue(of(claimedTaskDetailsMock));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();

const saveButton = fixture.debugElement.nativeElement.querySelector('[id="adf-form-save"]');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-form-complete');
const claimButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-claim-button"]'));
const releaseButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-unclaim-button"]'));

expect(saveButton).not.toBeNull();
expect(saveButton['disabled']).toBe(false, 'Save button is disabled');
expect(completeButton).not.toBeNull();
expect(completeButton['disabled']).toBe(false, 'Complete button is disabled');
expect(releaseButton).not.toBeNull();
expect(releaseButton.nativeElement.disabled).toBe(false, 'Release button is disabled');
expect(claimButton).toBeNull();
});

it('Should show only the Claim button as enabled before claiming a task without form', async() => {
const claimableTaskDetailsWithoutFormMock = { ...claimableTaskDetailsMock, formKey: null };
getTaskDetailsSpy.and.returnValue(of(claimableTaskDetailsWithoutFormMock));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();

const cancelButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-cancel-button');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-complete-button');
const claimButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-claim-button"]'));
const releaseButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-unclaim-button"]'));

expect(cancelButton).not.toBeNull();
expect(completeButton).not.toBeNull();
expect(completeButton['disabled']).toEqual(true, 'Complete button is enabled');
expect(claimButton).not.toBeNull();
expect(claimButton.nativeElement.disabled).toBe(false, 'Claim button is disabled');
expect(releaseButton).toBeNull();
});

it('Should show only Complete/Release buttons as enabled after claiming a task without form', async() => {
const claimedTaskDetailsWithoutFormMock = { ...claimedTaskDetailsMock, formKey: null };
getBpmLoggedUserSpy.and.returnValue(of(claimedTaskDetailsWithoutFormMock.assignee));
getTaskDetailsSpy.and.returnValue(of(claimedTaskDetailsWithoutFormMock));
component.taskId = 'mock-task-id';
fixture.detectChanges();
await fixture.whenStable();

const cancelButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-cancel-button');
const completeButton = fixture.debugElement.nativeElement.querySelector('#adf-no-form-complete-button');
const claimButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-claim-button"]'));
const releaseButton = fixture.debugElement.query(By.css('[data-automation-id="adf-task-form-unclaim-button"]'));

expect(cancelButton).not.toBeNull();
expect(completeButton).not.toBeNull();
expect(completeButton['disabled']).toEqual(false, 'Complete button is disabled');
expect(releaseButton).not.toBeNull();
expect(releaseButton.nativeElement.disabled).toBe(false, 'Release button is disabled');
expect(claimButton).toBeNull();
});
});
});

0 comments on commit b77e037

Please sign in to comment.