-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAE-23116 Dropdown should not display errors / call apis when it's in readOnly state [without refactor] #9800
Merged
wiktord2000
merged 9 commits into
develop
from
fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors
Jun 21, 2024
Merged
AAE-23116 Dropdown should not display errors / call apis when it's in readOnly state [without refactor] #9800
wiktord2000
merged 9 commits into
develop
from
fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktord2000
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
June 12, 2024 07:56
tomgny
reviewed
Jun 12, 2024
lib/core/src/lib/form/components/widgets/core/form-field-validator.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
tomgny
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check comments,
- it would be nice to raise an issue for improvement this file and move some logic like parse to separate (new) service
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
tomgny
reviewed
Jun 12, 2024
lib/core/src/lib/form/components/widgets/core/form-field.model.ts
Outdated
Show resolved
Hide resolved
tomgny
approved these changes
Jun 12, 2024
wiktord2000
force-pushed
the
fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors
branch
from
June 18, 2024 20:38
41c1345
to
0a71d9f
Compare
wiktord2000
force-pushed
the
fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors
branch
from
June 20, 2024 13:44
0a71d9f
to
c0ab312
Compare
Quality Gate failedFailed conditions |
wiktord2000
deleted the
fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors
branch
June 21, 2024 06:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-23116
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: