Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-23116 Dropdown should not display errors / call apis when it's in readOnly state [without refactor] #9800

Conversation

wiktord2000
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-23116

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@wiktord2000 wiktord2000 marked this pull request as ready for review June 12, 2024 07:56
Copy link
Contributor

@tomgny tomgny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comments,

  • it would be nice to raise an issue for improvement this file and move some logic like parse to separate (new) service

@wiktord2000 wiktord2000 force-pushed the fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors branch from 41c1345 to 0a71d9f Compare June 18, 2024 20:38
@wiktord2000 wiktord2000 force-pushed the fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors branch from 0a71d9f to c0ab312 Compare June 20, 2024 13:44
Copy link

sonarcloud bot commented Jun 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@wiktord2000 wiktord2000 merged commit 4d2c489 into develop Jun 21, 2024
32 of 33 checks passed
@wiktord2000 wiktord2000 deleted the fix/AAE-23116-refactor-free-readonly-dropdown-should-not-display-errors branch June 21, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants