New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADF-4713] Add new DecimalNumber Pipe to transform and localize numbers #4926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add something about it also in docs/user-guide/localization.md ?
Codecov Report
@@ Coverage Diff @@
## development #4926 +/- ##
==============================================
Coverage ? 82.52%
==============================================
Files ? 743
Lines ? 22216
Branches ? 3315
==============================================
Hits ? 18334
Misses ? 2907
Partials ? 975
Continue to review full report at Codecov.
|
3e3a38d
to
ff0b9c5
Compare
ff0b9c5
to
2c14948
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some e2e relative to that are failing. Please give it a look
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-4713
What is the new behaviour?
A need of control and manipulate numbers was needed. That's why this new pipe has been created.
Now the user is in control of the number of digits in the integer part as well as the decimal part.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://issues.alfresco.com/jira/browse/ADF-4713