Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-4713] Add new DecimalNumber Pipe to transform and localize numbers #4926

Merged
merged 4 commits into from Jul 18, 2019

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Jul 12, 2019

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-4713

What is the new behaviour?
A need of control and manipulate numbers was needed. That's why this new pipe has been created.

Now the user is in control of the number of digits in the integer part as well as the decimal part.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/ADF-4713

lib/core/pipes/decimal-number.pipe.ts Outdated Show resolved Hide resolved
DenysVuika
DenysVuika previously approved these changes Jul 12, 2019
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add something about it also in docs/user-guide/localization.md ?

@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (development@1abb9bf). Click here to learn what that means.
The diff coverage is 80.88%.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #4926   +/-   ##
==============================================
  Coverage               ?   82.52%           
==============================================
  Files                  ?      743           
  Lines                  ?    22216           
  Branches               ?     3315           
==============================================
  Hits                   ?    18334           
  Misses                 ?     2907           
  Partials               ?      975
Impacted Files Coverage Δ
...core/card-view/models/card-view-floatitem.model.ts 88.88% <100%> (ø)
lib/core/models/public-api.ts 100% <100%> (ø)
lib/core/pipes/pipe.module.ts 100% <100%> (ø)
lib/core/pipes/localized-date.pipe.ts 100% <100%> (ø)
...ata/services/property-groups-translator.service.ts 98.11% <100%> (ø)
lib/core/pipes/public-api.ts 100% <100%> (ø)
lib/core/models/decimal-number.model.ts 33.33% <33.33%> (ø)
...re/form/components/widgets/number/number.widget.ts 76.92% <66.66%> (ø)
lib/core/pipes/decimal-number.pipe.ts 84.21% <84.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abb9bf...2c14948. Read the comment docs.

DenysVuika
DenysVuika previously approved these changes Jul 15, 2019
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some e2e relative to that are failing. Please give it a look

@eromano eromano merged commit a0d4160 into development Jul 18, 2019
@eromano eromano added this to the 3.4.0 milestone Jul 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the dev-dcano-ADF-4713 branch July 18, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants