Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-2478] Add margin to the form title to avoid overlaping the buttons #5685

Merged
merged 1 commit into from May 12, 2020

Conversation

BaptisteMahe
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix / Stylefix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
When the window is too small, in the form component, the validation and reload buttons may overlap the title if the title is too long.

What is the new behaviour?
The title has 55px of margin-left so it becomes multi-line before overlapping the buttons when the window is too short.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/AAE-2478

@BaptisteMahe BaptisteMahe requested a review from dhrn May 11, 2020 15:45
@eromano eromano merged commit 9b42a07 into develop May 12, 2020
@eromano eromano deleted the dev-baptiste-AAE-2478 branch May 12, 2020 10:55
@pr-triage pr-triage bot added the PR: merged label May 12, 2020
@eromano eromano added this to the 3.9.0 milestone May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants