Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e #5686

Merged
merged 7 commits into from May 12, 2020
Merged

fix e2e #5686

merged 7 commits into from May 12, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented May 11, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
fix e2e

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@27fd18c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5686   +/-   ##
==========================================
  Coverage           ?   83.66%           
==========================================
  Files              ?      908           
  Lines              ?    26442           
  Branches           ?     3727           
==========================================
  Hits               ?    22124           
  Misses             ?     3204           
  Partials           ?     1114           
Impacted Files Coverage Δ
...ts/gateways/diagram-exclusive-gateway.component.ts 100.00% <0.00%> (ø)
...re/viewer/directives/viewer-extension.directive.ts 64.28% <0.00%> (ø)
.../form/components/widgets/core/form-widget.model.ts 100.00% <0.00%> (ø)
...ponents/icons/diagram-icon-camel-task.component.ts 100.00% <0.00%> (ø)
lib/core/services/auth-guard-base.ts 87.87% <0.00%> (ø)
lib/core/mock/form/form.service.mock.ts 100.00% <0.00%> (ø)
lib/core/pipes/mime-type-icon.pipe.ts 100.00% <0.00%> (ø)
lib/core/services/external-alfresco-api.service.ts 42.30% <0.00%> (ø)
...ib/core/login/components/login-dialog.component.ts 55.55% <0.00%> (ø)
.../core/card-view/models/card-view-baseitem.model.ts 95.65% <0.00%> (ø)
... and 898 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27fd18c...5d82b25. Read the comment docs.

@VitoAlbano VitoAlbano merged commit f72f82e into develop May 12, 2020
@VitoAlbano VitoAlbano deleted the dev-eromano-fix-e2e branch May 12, 2020 09:04
@pr-triage pr-triage bot added the PR: merged label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants