Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-1606] use new api siteservice #5693

Merged
merged 3 commits into from May 13, 2020
Merged

Conversation

eromano
Copy link
Contributor

@eromano eromano commented May 13, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
use new api siteservice to use memebership

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

Codecov Report

Merging #5693 into develop will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5693      +/-   ##
===========================================
+ Coverage    83.64%   83.67%   +0.02%     
===========================================
  Files          908      908              
  Lines        26457    26459       +2     
  Branches      3730     3730              
===========================================
+ Hits         22131    22139       +8     
+ Misses        3211     3203       -8     
- Partials      1115     1117       +2     
Impacted Files Coverage Δ
lib/core/services/sites.service.ts 58.06% <83.33%> (+2.89%) ⬆️
...lib/process-comments/process-comments.component.ts 71.69% <0.00%> (-1.89%) ⬇️
lib/core/services/translate-loader.service.ts 81.01% <0.00%> (+8.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d59f7...3d40174. Read the comment docs.

@eromano eromano merged commit b76bb75 into develop May 13, 2020
@eromano eromano deleted the dev-eromano-siteservicerefactor branch May 13, 2020 13:08
@pr-triage pr-triage bot added the PR: merged label May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants