Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to evaluate an object as payload #5697

Merged
merged 1 commit into from May 13, 2020
Merged

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented May 13, 2020

Codecov Report

Merging #5697 into develop will decrease coverage by 20.83%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5697       +/-   ##
============================================
- Coverage    83.68%   62.84%   -20.84%     
============================================
  Files          908        8      -900     
  Lines        26442      323    -26119     
  Branches      3727       68     -3659     
============================================
- Hits         22127      203    -21924     
+ Misses        3201      110     -3091     
+ Partials      1114       10     -1104     
Impacted Files Coverage Δ
...b/extensions/src/lib/services/extension.service.ts 89.18% <42.85%> (-4.93%) ⬇️
...ices-cloud/src/lib/services/cloud-token.service.ts
...ocess-list/components/process-filters.component.ts
lib/core/form/services/node.service.ts
...l/icons/raphael-icon-alfresco-publish.component.ts
lib/core/models/ecm-user.model.ts
...ib/core/datatable/data/object-datatable-adapter.ts
...k-list/components/task-form/task-form.component.ts
lib/core/mock/comment-content-service.mock.ts
.../datatable/components/datatable/data-cell.event.ts
... and 891 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db9fb0...8d4a2e4. Read the comment docs.

@eromano eromano merged commit 0186d11 into develop May 13, 2020
@eromano eromano deleted the mvitale-payload-object branch May 13, 2020 21:19
@pr-triage pr-triage bot added the PR: merged label May 13, 2020
@arditdomi arditdomi restored the mvitale-payload-object branch June 23, 2020 09:57
@arditdomi arditdomi deleted the mvitale-payload-object branch June 23, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants