Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3316] Fix process filters selection should reset if input changes to non ex… #5698

Merged
merged 2 commits into from May 14, 2020

Conversation

arditdomi
Copy link
Contributor

@arditdomi arditdomi commented May 13, 2020

…isting filter

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3316

What is the new behaviour?
If there is any selected filter when the filterParam input changes to a non existing filter, the filter selection is cleared

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@arditdomi arditdomi changed the title [ACA-3316] Fix process filter should reset if input changes to non ex… [ACA-3316] Fix process filters selection should reset if input changes to non ex… May 13, 2020
Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit test

@codecov-io
Copy link

Codecov Report

Merging #5698 into develop will increase coverage by 1.25%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5698      +/-   ##
===========================================
+ Coverage    83.68%   84.93%   +1.25%     
===========================================
  Files          908       91     -817     
  Lines        26479     3393   -23086     
  Branches      3733      445    -3288     
===========================================
- Hits         22160     2882   -19278     
+ Misses        3202      377    -2825     
+ Partials      1117      134     -983     
Impacted Files Coverage Δ
...lib/task-list/components/task-filters.component.ts 76.25% <ø> (ø)
...ocess-list/components/process-filters.component.ts 80.26% <80.00%> (-1.08%) ⬇️
...k-list/components/task-form/task-form.component.ts 89.71% <0.00%> (-0.46%) ⬇️
...ib/process-services/src/lib/form/form.component.ts 89.50% <0.00%> (-0.06%) ⬇️
...ponents/icons/diagram-icon-camel-task.component.ts
lib/core/events/base-ui.event.ts
lib/core/form/services/node.service.ts
.../add-permission/add-permission-dialog.component.ts
...ponents/unknown-format/unknown-format.component.ts
lib/core/layout/index.ts
... and 814 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b79439...9c03769. Read the comment docs.

@eromano eromano merged commit 7d4a956 into develop May 14, 2020
@eromano eromano deleted the dev-adomi-ACA-3316 branch May 14, 2020 11:22
@pr-triage pr-triage bot added the PR: merged label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants