Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-2478] Long task title show ellipsis when too long and add tool tip to task title inside form #5704

Merged
merged 4 commits into from May 22, 2020

Conversation

BaptisteMahe
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
The title of a task inside the form renderer is wrapped into several lines when too long.

What is the new behaviour?
That title now always displays a tooltip when hovered and show ellipsis format when too long. (Same behaviour for PS and cloud)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/AAE-2478

@BaptisteMahe BaptisteMahe requested a review from dhrn May 14, 2020 16:00
@BaptisteMahe BaptisteMahe changed the title Long task title show ellipsis when too and add tool tip to task title inside form [AAE-2478] Long task title show ellipsis when too and add tool tip to task title inside form May 15, 2020
@codecov-io
Copy link

codecov-io commented May 15, 2020

Codecov Report

Merging #5704 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5704      +/-   ##
===========================================
+ Coverage    83.66%   83.76%   +0.09%     
===========================================
  Files          908      941      +33     
  Lines        26470    26648     +178     
  Branches      3733     3740       +7     
===========================================
+ Hits         22147    22322     +175     
  Misses        3205     3205              
- Partials      1118     1121       +3     
Impacted Files Coverage Δ
.../core/services/dynamic-component-mapper.service.ts 87.09% <0.00%> (-12.91%) ⬇️
lib/core/services/translate-loader.service.ts 72.15% <0.00%> (-8.87%) ⬇️
...b/extensions/src/lib/services/extension.service.ts 89.18% <0.00%> (-4.93%) ⬇️
lib/core/services/sites.service.ts 51.21% <0.00%> (-3.96%) ⬇️
...process-list/components/start-process.component.ts 85.43% <0.00%> (-1.65%) ⬇️
...ters/components/process-filters-cloud.component.ts 92.18% <0.00%> (-1.37%) ⬇️
...-selector/content-node-selector-panel.component.ts 93.47% <0.00%> (-0.64%) ⬇️
...k-list/components/task-form/task-form.component.ts 89.71% <0.00%> (-0.46%) ⬇️
...e/form/components/widgets/core/form-field.model.ts 90.51% <0.00%> (-0.36%) ⬇️
...ud/src/lib/form/components/form-cloud.component.ts 88.67% <0.00%> (-0.08%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da489a...accbf05. Read the comment docs.

@BaptisteMahe BaptisteMahe changed the title [AAE-2478] Long task title show ellipsis when too and add tool tip to task title inside form [AAE-2478] Long task title show ellipsis when too long and add tool tip to task title inside form May 18, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #5704 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5704      +/-   ##
===========================================
+ Coverage    83.66%   83.83%   +0.16%     
===========================================
  Files          908      943      +35     
  Lines        26470    26828     +358     
  Branches      3733     3776      +43     
===========================================
+ Hits         22147    22492     +345     
- Misses        3205     3219      +14     
+ Partials      1118     1117       -1     
Impacted Files Coverage Δ
.../core/services/dynamic-component-mapper.service.ts 87.09% <0.00%> (-12.91%) ⬇️
lib/core/services/translate-loader.service.ts 72.15% <0.00%> (-8.87%) ⬇️
...c/lib/upload/components/upload-button.component.ts 84.48% <0.00%> (-5.91%) ⬇️
lib/content-services/src/lib/content.module.ts 91.42% <0.00%> (-5.13%) ⬇️
...b/extensions/src/lib/services/extension.service.ts 89.18% <0.00%> (-4.93%) ⬇️
lib/core/services/cookie.service.ts 54.54% <0.00%> (-4.55%) ⬇️
lib/core/services/sites.service.ts 51.21% <0.00%> (-3.96%) ⬇️
...ud/src/lib/task/directives/claim-task.directive.ts 91.42% <0.00%> (-2.86%) ⬇️
lib/insights/src/lib/insights.module.ts 92.30% <0.00%> (-2.70%) ⬇️
lib/core/form/services/form.service.ts 70.30% <0.00%> (-2.43%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6da489a...12d71a8. Read the comment docs.

@eromano eromano merged commit 7a6a86e into develop May 22, 2020
@eromano eromano deleted the dev-baptiste-AAE-2478 branch May 22, 2020 08:36
@pr-triage pr-triage bot added the PR: merged label May 22, 2020
@eromano eromano added this to the 3.9.0 milestone May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants