Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-45] Drag and Drop a New Version #5710

Merged
merged 20 commits into from May 20, 2020
Merged

[ACA-45] Drag and Drop a New Version #5710

merged 20 commits into from May 20, 2020

Conversation

ursedaniel
Copy link
Contributor

@ursedaniel ursedaniel commented May 18, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-45
Currently I can not drop a file over another file to update it's version, I can only drop a file into a folder to upload it there.

What is the new behaviour?

I can drag&drop a file over another file and the dialog for updating it's version will appear and after I specific the version(minor, major) and adding a comment (as optional) i can upload it's version right away.
Also I've added an option in the demo shell to enable/disable this feature.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

…only checking if the value is passed to the share-data-row
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #5710 into develop will increase coverage by 0.05%.
The diff coverage is 82.60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5710      +/-   ##
===========================================
+ Coverage    83.67%   83.73%   +0.05%     
===========================================
  Files          908      941      +33     
  Lines        26442    26674     +232     
  Branches      3727     3752      +25     
===========================================
+ Hits         22126    22335     +209     
- Misses        3203     3215      +12     
- Partials      1113     1124      +11     
Impacted Files Coverage Δ
...atable/components/datatable/datatable.component.ts 88.01% <ø> (+0.23%) ⬆️
...c/lib/upload/components/upload-button.component.ts 84.48% <33.33%> (-5.91%) ⬇️
...ib/upload/components/upload-drag-area.component.ts 76.19% <72.72%> (-0.74%) ⬇️
...src/lib/document-list/data/share-data-row.model.ts 81.48% <88.88%> (+0.63%) ⬆️
...ocument-list/components/document-list.component.ts 85.47% <100.00%> (ø)
.../lib/document-list/data/share-datatable-adapter.ts 76.92% <100.00%> (+0.66%) ⬆️
...c/lib/upload/components/base-upload/upload-base.ts 100.00% <100.00%> (ø)
...c/lib/version-manager/version-manager.component.ts 79.48% <100.00%> (+3.01%) ⬆️
...rc/lib/version-manager/version-upload.component.ts 68.42% <100.00%> (+1.75%) ⬆️
.../core/services/dynamic-component-mapper.service.ts 87.09% <0.00%> (-12.91%) ⬇️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b42a07...6999e86. Read the comment docs.

@eromano eromano merged commit 4cb3a87 into develop May 20, 2020
@eromano eromano deleted the dev-durse-ACA-45 branch May 20, 2020 10:57
@eromano eromano added this to the 3.9.0 milestone May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants