New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-45] Drag and Drop a New Version #5710
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the input for uploading should be button instead of file
… file as input, the type of the input should be 'button' instead of 'file'
…ped file. also emitting a new event for updating file version if i'm dropping a single file over another file.
…d also handle a new event when we update the file version
ursedaniel
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
May 18, 2020 10:23
DenysVuika
reviewed
May 18, 2020
DenysVuika
requested changes
May 18, 2020
lib/content-services/src/lib/upload/components/upload-version-button.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/upload/components/upload-version-button.component.ts
Outdated
Show resolved
Hide resolved
lib/core/datatable/components/datatable/datatable.component.html
Outdated
Show resolved
Hide resolved
eromano
requested changes
May 18, 2020
lib/core/datatable/components/datatable/datatable.component.html
Outdated
Show resolved
Hide resolved
…only checking if the value is passed to the share-data-row
Codecov Report
@@ Coverage Diff @@
## develop #5710 +/- ##
===========================================
+ Coverage 83.67% 83.73% +0.05%
===========================================
Files 908 941 +33
Lines 26442 26674 +232
Branches 3727 3752 +25
===========================================
+ Hits 22126 22335 +209
- Misses 3203 3215 +12
- Partials 1113 1124 +11
Continue to review full report at Codecov.
|
DenysVuika
approved these changes
May 19, 2020
eromano
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-45
Currently I can not drop a file over another file to update it's version, I can only drop a file into a folder to upload it there.
What is the new behaviour?
I can drag&drop a file over another file and the dialog for updating it's version will appear and after I specific the version(minor, major) and adding a comment (as optional) i can upload it's version right away.
Also I've added an option in the demo shell to enable/disable this feature.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: