Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3314] Add cancelButton and noFormTemplate form elements #5723

Merged
merged 3 commits into from May 22, 2020

Conversation

iuliaib
Copy link
Contributor

@iuliaib iuliaib commented May 22, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

  1. FormFields page:
  • Add missing noFormTemplate and cancelButton elements in FormFields;
  • Add isNoFormTemplateDisplayed() method that is checking if the template (not the message) of a task without a form is displayed;
  • Add isCancelButtonDisplayed() method to check if Cancel button is displayed;
  • Add isCancelButtonEnabled() method to check if Cancel button is enabled;
  • Add clickCancelButton() method - this action is possible on a task without form;
  1. TaskListPage:
  • Add a rootElement for task list;

iuliaib added 3 commits May 22, 2020 16:35
1. FormFields page:
- Add missing `noFormTemplate` and `cancelButton` elements in FormFields;
- Add `isNoFormTemplateDisplayed()` method that is checking if the template (not the message) of a task without a form is displayed;
- Add `isCancelButtonDisplayed()` method to check if `Cancel` button is displayed;
- Add `isCancelButtonEnabled()` method to check if `Cancel` button is enabled;
- Add `clickCancelButton()` method - this action is possible on a task without form;

2. TaskListPage:
- Add a rootElement for task list;
@CLAassistant
Copy link

CLAassistant commented May 22, 2020

CLA assistant check
All committers have signed the CLA.

@mauriziovitale mauriziovitale merged commit a8251fa into develop May 22, 2020
@mauriziovitale mauriziovitale deleted the dev-iburca-ACA-3314 branch May 22, 2020 16:09
@pr-triage pr-triage bot added the PR: merged label May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants