Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-2989]Add doubleClickRow method #5728

Merged
merged 8 commits into from
Jun 5, 2020
Merged

[ACA-2989]Add doubleClickRow method #5728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
06cda8c
Add doubleClickRow method
cristinaj May 27, 2020
e85226f
Renamed the method to be in sync with the actions made
cristinaj May 27, 2020
8bc6897
Modified the columns parameter from 'any' to 'Column[]'
cristinaj May 29, 2020
26845f4
no message
cristinaj May 29, 2020
12ca394
Make Column abstract again
cristinaj Jun 2, 2020
1cf8561
Add locators snackbar action
cristinaj Jun 5, 2020
fd551b2
Unblock Travis
cristinaj Jun 5, 2020
f488860
no message
cristinaj Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/testing/src/lib/core/pages/data-table/column.ts
View file
Open in desktop
Expand Up @@ -18,10 +18,10 @@
export abstract class Column {
columnName: string;
columnType: string;
locator: string;

constructor(columnName: string) {
constructor(columnName: string, columnType: string ) {
this.columnName = columnName;
this.columnType = columnType;
}

createLocator(columnValue: string): string {
Expand Down
2 changes: 1 addition & 1 deletion lib/testing/src/lib/core/pages/data-table/data-table-builder.ts
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ import { ElementFinder } from 'protractor';

export class DataTableBuilder {

createDataTable(columns: Array<Column>, rootElement?: ElementFinder): DataTableItem {
createDataTable(columns: Column[], rootElement?: ElementFinder): DataTableItem {
const datatable: DataTableItem = new DataTableItem(rootElement);
for (const column of columns) {
switch (column.columnType) {
Expand Down
8 changes: 7 additions & 1 deletion lib/testing/src/lib/core/pages/data-table/data-table-item.ts
View file
Open in desktop
Expand Up @@ -16,7 +16,7 @@
*/

import { Column } from './column';
import { by, element, ElementFinder, Locator } from 'protractor';
import { by, element, ElementFinder, Locator, protractor, browser } from 'protractor';
import { BrowserActions } from '../../utils/browser-actions';
import { BrowserVisibility } from '../../utils/browser-visibility';

Expand Down Expand Up @@ -59,4 +59,10 @@ export class DataTableItem {
async waitForFirstRow(): Promise<void> {
await BrowserVisibility.waitUntilElementIsVisible(this.rootElement.all(this.rows).first());
}

async clickAndEnterOnRow(columnName: string, columnValue: string): Promise<void> {
const row = this.getRow(columnName, columnValue);
await BrowserActions.click(row);
await browser.actions().sendKeys(protractor.Key.ENTER).perform();
}
}
4 changes: 2 additions & 2 deletions lib/testing/src/lib/core/pages/data-table/date-column.ts
View file
Open in desktop
Expand Up @@ -18,10 +18,10 @@
import { Column } from './column';

export class DateColumn extends Column {
columnType: string = 'date';
columnType: string;
columnName: string;

constructor(columnName: string) {
super(columnName);
super(columnName, 'date');
}
}
4 changes: 2 additions & 2 deletions lib/testing/src/lib/core/pages/data-table/text-column.ts
View file
Open in desktop
Expand Up @@ -18,10 +18,10 @@
import { Column } from './column';

export class TextColumn extends Column {
columnType: string = 'text';
columnType: string;
columnName: string;

constructor(columnName: string) {
super(columnName);
super(columnName, 'text');
}
}
12 changes: 12 additions & 0 deletions lib/testing/src/lib/core/pages/snackbar.page.ts
View file
Open in desktop
Expand Up @@ -17,10 +17,12 @@

import { element, by, ElementFinder } from 'protractor';
import { BrowserVisibility } from '../utils/browser-visibility';
import { BrowserActions } from '../utils/browser-actions';

export class SnackbarPage {

notificationSnackBar: ElementFinder = element.all(by.css('simple-snack-bar span')).first();
snackBarAction: ElementFinder = element(by.css('simple-snack-bar button span'));
snackBarContainerCss = by.css('.mat-snack-bar-container');

async waitForSnackBarToAppear() {
Expand All @@ -38,6 +40,16 @@ export class SnackbarPage {
return this.notificationSnackBar.getText();
}

async getSnackBarActionMessage(): Promise<string> {
await this.waitForSnackBarToAppear();
return this.snackBarAction.getText();
}

async clickSnackBarAction(): Promise<void> {
await this.waitForSnackBarToAppear();
await BrowserActions.click(this.snackBarAction);
}

async isNotificationSnackBarDisplayed(): Promise<boolean> {
try {
await BrowserVisibility.waitUntilElementIsVisible(this.notificationSnackBar, 2000);
Expand Down