[ACA-3368] Update datatable columns when presetColumn schema changes #5732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arditdomi
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5732 +/- ##
===========================================
+ Coverage 83.73% 83.79% +0.05%
===========================================
Files 943 943
Lines 26759 26774 +15
Branches 3765 3768 +3
===========================================
+ Hits 22407 22434 +27
+ Misses 3229 3214 -15
- Partials 1123 1126 +3
Continue to review full report at Codecov.
|
arditdomi
force-pushed
the
dev-adomi-ACA-3368
branch
from
479059f
to
0ec5648
Compare
| it('should update data columns when columns input changes', () => { | ||
| dataTable.data = new ObjectDataTableAdapter( | ||
| [{ id: 'fake-data' }], | ||
| [new ObjectDataColumn({ key: 'id' })] |
There was a problem hiding this comment.
can we use column-1 column-2 to make clear what we are testing?
| @@ -244,6 +245,15 @@ export class DataTableComponent implements AfterContentInit, OnChanges, DoCheck, | |||
| return; | |||
| } | |||
|
|
|||
| if (this.isPropertyChanged(changes['columns'])) { | |||
There was a problem hiding this comment.
can we rewrite it like
if (this.isPropertyChanged(changes['rows'] || this.isPropertyChanged(changes['columns'])) {
if (this.isTableEmpty()) {
this.initTable();
}
if (this.isPropertyChanged(changes['rows']) {
this.setTableRows(changes['rows'].currentValue);
} else {
this.setTableColumns(changes['columns'].currentValue);
}
return;
}
| component.columns = []; | ||
| const presetColumnChange = new SimpleChange(null, 'fakeProcessCustomSchema', false); | ||
| component.ngOnChanges({ 'presetColumn': presetColumnChange }); | ||
| expect(component.columns).toEqual(component.mergeJsonAndHtmlSchema()); |
There was a problem hiding this comment.
don't get it.
can we have a column preset, i.e. col-1 col-2
we change it and we expect to have col-3 col-4 ?
| component.columns = []; | ||
| const presetColumnChange = new SimpleChange(null, 'fakeCustomSchema', false); | ||
| component.ngOnChanges({ 'presetColumn': presetColumnChange }); | ||
| expect(component.columns).toEqual(component.mergeJsonAndHtmlSchema()); |
mauriziovitale
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3368
What is the new behaviour?
The columns are updating when the schema changes
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: