Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3252] Content Metadata - Use the translation key #5737

Merged
merged 1 commit into from May 29, 2020

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Value not translated

What is the new behaviour?
Value should be translated

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #5737 into develop will increase coverage by 2.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5737      +/-   ##
===========================================
+ Coverage    83.73%   86.15%   +2.41%     
===========================================
  Files          943      173     -770     
  Lines        26776     5264   -21512     
  Branches      3767      748    -3019     
===========================================
- Hits         22421     4535   -17886     
+ Misses        3232      498    -2734     
+ Partials      1123      231     -892     
Impacted Files Coverage Δ
lib/core/app-config/app-config.service.ts
...ons/src/lib/services/component-register.service.ts
lib/core/viewer/services/view-util.service.ts
...re/viewer/components/pdf-viewer-password-dialog.ts
lib/extensions/src/lib/config/extension-utils.ts
.../directives/check-allowable-operation.directive.ts
...m/components/widgets/date-time/date-time.widget.ts
lib/core/models/product-version.model.ts
...datatable/directives/loading-template.directive.ts
lib/core/models/identity-role.model.ts
... and 760 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84607de...134b585. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants