Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5153] Transclusion exposed from the DataTable to the DocumentList #5743

Merged
merged 3 commits into from Jun 2, 2020

Conversation

BaptisteMahe
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
No content exposed from the DataTable to the DocumentList.

What is the new behaviour?
In order to implement the facet widget to filter the DataTable we need some exposed content of the DataTable inside the DocumentList.
This is done using the ng-template element through those two components.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://issues.alfresco.com/jira/browse/ADF-5153

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #5743 into develop will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5743      +/-   ##
===========================================
+ Coverage    83.78%   83.81%   +0.02%     
===========================================
  Files          943      943              
  Lines        26791    26795       +4     
  Branches      3770     3770              
===========================================
+ Hits         22447    22457      +10     
+ Misses        3218     3214       -4     
+ Partials      1126     1124       -2     
Impacted Files Coverage Δ
...ocument-list/components/document-list.component.ts 85.51% <100.00%> (+0.04%) ⬆️
...atable/components/datatable/datatable.component.ts 88.15% <100.00%> (+0.06%) ⬆️
.../lib/task-list/components/attach-form.component.ts 55.35% <0.00%> (-7.15%) ⬇️
...ud/src/lib/form/components/form-cloud.component.ts 88.75% <0.00%> (+0.07%) ⬆️
lib/core/services/upload.service.ts 88.38% <0.00%> (+3.03%) ⬆️
...t/components/process-instance-details.component.ts 84.90% <0.00%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3649e92...d4b5bdb. Read the comment docs.

@VitoAlbano VitoAlbano merged commit 439e3c7 into develop Jun 2, 2020
@VitoAlbano VitoAlbano deleted the dev-baptiste-ADF-5153 branch June 2, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants