Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3286] User gets error when removing the attached file #5744

Merged
merged 1 commit into from Jun 2, 2020

Conversation

mcchrys
Copy link
Contributor

@mcchrys mcchrys commented Jun 2, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3286

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@mcchrys mcchrys changed the title [ACA-3286] User gets error when removing the attached file (#5735) [ACA-3286] User gets error when removing the attached file Jun 2, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #5744 into develop will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5744      +/-   ##
===========================================
- Coverage    83.75%   83.73%   -0.02%     
===========================================
  Files          943      943              
  Lines        26792    26793       +1     
  Branches      3770     3770              
===========================================
- Hits         22439    22435       -4     
- Misses        3230     3234       +4     
- Partials      1123     1124       +1     
Impacted Files Coverage Δ
...form/components/form-field/form-field.component.ts 61.76% <0.00%> (-0.93%) ⬇️
...ponents/widgets/attach-file/upload-cloud.widget.ts 77.94% <0.00%> (ø)
...t/components/process-instance-details.component.ts 77.35% <0.00%> (-7.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b06fd6...dc20cd8. Read the comment docs.

@popovicsandras popovicsandras merged commit 6890dea into develop Jun 2, 2020
@popovicsandras popovicsandras deleted the dev-mrc-aca-3286 branch June 2, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants