Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3382] Expression - Fix the obj reference #5749

Merged
merged 1 commit into from Jun 3, 2020

Conversation

mauriziovitale
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #5749 into develop will decrease coverage by 21.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5749       +/-   ##
============================================
- Coverage    83.76%   62.65%   -21.12%     
============================================
  Files          943        8      -935     
  Lines        26796      324    -26472     
  Branches      3770       68     -3702     
============================================
- Hits         22446      203    -22243     
+ Misses        3225      111     -3114     
+ Partials      1125       10     -1115     
Impacted Files Coverage Δ
...b/extensions/src/lib/services/extension.service.ts 88.00% <0.00%> (-1.19%) ⬇️
...rt-process/services/start-process-cloud.service.ts
...e/form/components/widgets/error/error.component.ts
...-services/src/lib/task-list/models/filter.model.ts
...ts/raphael/icons/raphael-icon-message.component.ts
lib/content-services/src/lib/upload/public-api.ts
...s/src/lib/app-list/select-apps-dialog.component.ts
...-services/src/lib/permission-manager/public-api.ts
...s-services/src/lib/attachment/attachment.module.ts
.../form/components/widgets/core/form-widget.model.ts
... and 926 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6890dea...b8d3fa4. Read the comment docs.

@mauriziovitale mauriziovitale merged commit d667c93 into develop Jun 3, 2020
@mauriziovitale mauriziovitale deleted the mvitale-ACA-3382-firstselection branch June 3, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants