Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3266] Improve version upload component #5750

Merged
merged 10 commits into from Jun 4, 2020
Merged

Conversation

ursedaniel
Copy link
Contributor

@ursedaniel ursedaniel commented Jun 3, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3266

What is the new behaviour?

I can see a comparison between the current node version and the new one after the drag&drop action.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #5750 into develop will increase coverage by 2.35%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5750      +/-   ##
===========================================
+ Coverage    83.76%   86.11%   +2.35%     
===========================================
  Files          943      174     -769     
  Lines        26796     5280   -21516     
  Branches      3770      748    -3022     
===========================================
- Hits         22446     4547   -17899     
+ Misses        3225      502    -2723     
+ Partials      1125      231     -894     
Impacted Files Coverage Δ
...c/lib/version-manager/version-manager.component.ts 75.55% <50.00%> (-3.94%) ⬇️
...ib/version-manager/version-comparison.component.ts 100.00% <100.00%> (ø)
.../src/lib/version-manager/version-manager.module.ts 100.00% <100.00%> (ø)
...ib/document-list/services/document-list.service.ts 79.36% <0.00%> (-1.59%) ⬇️
...templates/empty-content/empty-content.component.ts
.../src/lib/process/services/process-cloud.service.ts
lib/core/services/comment-content.service.ts
...ts/src/lib/diagram/components/diagram.component.ts
...server-settings/about-server-settings.component.ts
lib/core/services/log.service.ts
... and 765 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6890dea...3dba614. Read the comment docs.

@eromano eromano deleted the dev-durse-ACA-3266 branch June 4, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants