New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-3266] Improve version upload component #5750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursedaniel
requested review from
DenysVuika,
eromano,
m-hulbert and
popovicsandras
as code owners
June 3, 2020 13:22
Codecov Report
@@ Coverage Diff @@
## develop #5750 +/- ##
===========================================
+ Coverage 83.76% 86.11% +2.35%
===========================================
Files 943 174 -769
Lines 26796 5280 -21516
Branches 3770 748 -3022
===========================================
- Hits 22446 4547 -17899
+ Misses 3225 502 -2723
+ Partials 1125 231 -894 Continue to review full report at Codecov.
|
eromano
requested changes
Jun 3, 2020
lib/content-services/src/lib/version-manager/version-comparison.component.spec.ts
Show resolved
Hide resolved
lib/content-services/src/lib/version-manager/version-comparison.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/version-manager/version-manager.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/version-manager/version-comparison.component.scss
Outdated
Show resolved
Hide resolved
eromano
approved these changes
Jun 4, 2020
…oaded a new file version
…-components into dev-durse-ACA-3266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3266
What is the new behaviour?
I can see a comparison between the current node version and the new one after the drag&drop action.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: