[ACA-3416] Add Claim/Release actions on adf task form #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivakumar414ram
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #5753 +/- ##
===========================================
+ Coverage 83.76% 84.60% +0.84%
===========================================
Files 945 203 -742
Lines 26858 7244 -19614
Branches 3775 1035 -2740
===========================================
- Hits 22497 6129 -16368
+ Misses 3234 807 -2427
+ Partials 1127 308 -819
Continue to review full report at Codecov.
|
eromano
requested changes
Jun 5, 2020
lib/process-services/src/lib/task-list/components/task-form/claim-task.directive.spec.ts
Show resolved
Hide resolved
| @@ -117,6 +117,14 @@ export class TaskFormComponent implements OnInit { | |||
| @Output() | |||
| cancel = new EventEmitter<void>(); | |||
|
|
|||
| /** Emitted when the task is claimed. */ | |||
| @Output() | |||
| claim: EventEmitter<any> = new EventEmitter<any>(); | |||
There was a problem hiding this comment.
not sure this logic should be in the form
There was a problem hiding this comment.
we have the same on the task form cloud. The name of the event should be changed. @eromano https://github.com/Alfresco/alfresco-ng2-components/blob/develop/lib/process-services-cloud/src/lib/task/task-form/components/task-form-cloud.component.ts#L78
There was a problem hiding this comment.
Let's call them as the one in the cloud
sivakumar414ram
force-pushed
the
dev-siva-ACA-3416-add-claim-release-actions-on-task-form
branch
from
77487a3
to
39d22f4
Compare
lib/process-services/src/lib/task-list/components/task-form/claim-task.directive.spec.ts
Show resolved
Hide resolved
mauriziovitale
requested changes
Jun 8, 2020
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: unreviewed
PR: reviewed-changes-requested
labels
mauriziovitale
approved these changes
Jun 9, 2020
arditdomi
suggested changes
Jun 9, 2020
docs/process-services-cloud/directives/unclaim-task-cloud.directive.md
Outdated
Show resolved
Hide resolved
docs/process-services-cloud/directives/unclaim-task-cloud.directive.md
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
pr-triage
bot
added
PR: reviewed-changes-requested
PR: unreviewed
and removed
PR: partially-approved
PR: reviewed-changes-requested
labels
* Changed cloud directive names
* Add unit test too
sivakumar414ram
force-pushed
the
dev-siva-ACA-3416-add-claim-release-actions-on-task-form
branch
from
cd7718f
to
a3ecd11
Compare
arditdomi
suggested changes
Jun 9, 2020
docs/process-services-cloud/directives/claim-task-cloud.directive.md
Outdated
Show resolved
Hide resolved
arditdomi
approved these changes
Jun 9, 2020
mauriziovitale
deleted the
dev-siva-ACA-3416-add-claim-release-actions-on-task-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3416
Task form does not have claim/release actions as part the form actions.
What is the new behaviour?
Now if the Task been shared among the candidate, task form will show claim/release actions based on the task status
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: