Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3266] Improve version upload component #5766

Merged
merged 11 commits into from Jun 10, 2020
Merged

Conversation

ursedaniel
Copy link
Contributor

@ursedaniel ursedaniel commented Jun 10, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-3266

What is the new behaviour?

Added the new component to be visible in public-api

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

Codecov Report

Merging #5766 into develop will increase coverage by 2.35%.
The diff coverage is 81.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5766      +/-   ##
===========================================
+ Coverage    83.76%   86.11%   +2.35%     
===========================================
  Files          943      175     -768     
  Lines        26796     5288   -21508     
  Branches      3770      748    -3022     
===========================================
- Hits         22446     4554   -17892     
+ Misses        3225      503    -2722     
+ Partials      1125      231     -894     
Impacted Files Coverage Δ
...c/lib/version-manager/version-manager.component.ts 75.55% <50.00%> (-3.94%) ⬇️
...ent-services/src/lib/version-manager/public-api.ts 100.00% <100.00%> (ø)
...ib/version-manager/version-comparison.component.ts 100.00% <100.00%> (ø)
.../src/lib/version-manager/version-manager.module.ts 100.00% <100.00%> (ø)
...ib/document-list/services/document-list.service.ts 79.36% <0.00%> (-1.59%) ⬇️
...ices/src/lib/document-list/document-list.module.ts 100.00% <0.00%> (ø)
lib/core/services/directionality-config.service.ts
.../src/lib/group/components/group-cloud.component.ts
lib/core/pipes/user-initial.pipe.ts
...ib/core/datatable/data/object-datatable-adapter.ts
... and 768 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6890dea...ca73bca. Read the comment docs.

@eromano eromano merged commit c86b193 into develop Jun 10, 2020
@eromano eromano deleted the dev-durse-ACA-3266 branch June 10, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants