Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-3201] Fix datatable styling non-sortable with sortable columns are not a… #5771

Merged
merged 1 commit into from Jun 11, 2020

Conversation

arditdomi
Copy link
Contributor

@arditdomi arditdomi commented Jun 11, 2020

…ligned

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ACA-3201

What is the new behaviour?
Hardcoded padding value for sortable columns is removed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@arditdomi arditdomi changed the title [ACA-3201] Fix datatable non-sortable with sortable columns are not a… [ACA-3201] Fix datatable styling non-sortable with sortable columns are not a… Jun 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #5771 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5771      +/-   ##
===========================================
+ Coverage    83.83%   83.84%   +0.01%     
===========================================
  Files          955      955              
  Lines        27021    27021              
  Branches      3802     3802              
===========================================
+ Hits         22653    22656       +3     
+ Misses        3242     3239       -3     
  Partials      1126     1126              
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 57.14% <0.00%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8025434...062eefb. Read the comment docs.

@arditdomi arditdomi merged commit d56bca3 into develop Jun 11, 2020
@arditdomi arditdomi deleted the dev-adomi-ACA-3201 branch June 11, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants