[ADF-5158] ECM Version Directive #5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcanonieto
requested review from
DenysVuika,
eromano,
m-hulbert and
popovicsandras
as code owners
eromano
approved these changes
Jun 16, 2020
dhrn
approved these changes
Jun 16, 2020
DenysVuika
requested changes
Jun 16, 2020
| } | ||
|
|
||
| private initCompatibilityVersion() { | ||
| this.discoveryApiService.getEcmProductInfo().toPromise().then( |
There was a problem hiding this comment.
don't use .toPromise because it is deprecated and will be soon removed
pr-triage
bot
added
PR: reviewed-changes-requested
and removed
PR: partially-approved
labels
|
I don't think "ECM" (enterprise content management) is the right term here, maybe "ACS" is better? |
Codecov Report
@@ Coverage Diff @@
## develop #5779 +/- ##
===========================================
+ Coverage 83.88% 83.93% +0.04%
===========================================
Files 960 963 +3
Lines 27164 27231 +67
Branches 3788 3798 +10
===========================================
+ Hits 22787 22855 +68
+ Misses 3247 3240 -7
- Partials 1130 1136 +6
Continue to review full report at Codecov.
|
eromano
requested changes
Jun 16, 2020
davidcanonieto
force-pushed
the
dev-dcano-ADF-5158
branch
from
aaea618
to
28fb5a2
Compare
davidcanonieto
force-pushed
the
dev-dcano-ADF-5158
branch
from
1f8bd09
to
058f417
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev-dcano-ADF-5158
branch
from
0f65480
to
252a549
Compare
|
I don't think you need to change the e2e they are working on develop |
davidcanonieto
force-pushed
the
dev-dcano-ADF-5158
branch
from
252a549
to
1813ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-5158
What is the new behaviour?
This new directive allows component to hide when the app is not running the ACS version required for them to work properly.
This means this button will be present in the DOM tree from 6.0.0 onwards. Otherwise it will be removed to avoid the component breaking the app.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: