Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5160] Fix CardView Key-Value Pairs Item overflowing #5790

Merged
merged 1 commit into from Jun 17, 2020

Conversation

davidcanonieto
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/ADF-5160
The CardView Key-Value Pairs Item overflows and does not adapt to the container it's embedded in.

What is the new behaviour?
It's been fixed to adjust to the real width size. 50% each since there are two columns.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #5790 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5790      +/-   ##
===========================================
- Coverage    83.84%   83.82%   -0.02%     
===========================================
  Files          955      955              
  Lines        27021    27021              
  Branches      3804     3804              
===========================================
- Hits         22655    22651       -4     
- Misses        3238     3241       +3     
- Partials      1128     1129       +1     
Impacted Files Coverage Δ
...t/components/process-instance-details.component.ts 77.35% <0.00%> (-7.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92aa7d...4c6c7ab. Read the comment docs.

@eromano eromano merged commit fe95673 into develop Jun 17, 2020
@eromano eromano deleted the dev-dcano-ADF-5160 branch June 17, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants