Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various code quality fixes #5792

Merged
merged 3 commits into from Jun 18, 2020
Merged

various code quality fixes #5792

merged 3 commits into from Jun 18, 2020

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

fix various issues found by static analysis tools:

  • missing await calls
  • simplify expressions

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #5792 into develop will increase coverage by 0.01%.
The diff coverage is 77.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5792      +/-   ##
===========================================
+ Coverage    83.84%   83.86%   +0.01%     
===========================================
  Files          955      955              
  Lines        27021    26992      -29     
  Branches      3804     3765      -39     
===========================================
- Hits         22655    22636      -19     
+ Misses        3238     3237       -1     
+ Partials      1128     1119       -9     
Impacted Files Coverage Δ
...ervices/src/lib/breadcrumb/breadcrumb.component.ts 84.50% <0.00%> (ø)
...ntent-node-selector/content-node-dialog.service.ts 84.14% <0.00%> (-0.20%) ⬇️
lib/core/dialogs/edit-json/edit-json.dialog.ts 46.15% <0.00%> (ø)
lib/core/form/components/form-base.component.ts 38.82% <0.00%> (ø)
...idgets/dynamic-table/dynamic-table.widget.model.ts 66.66% <0.00%> (ø)
lib/core/pipes/file-type.pipe.ts 75.00% <0.00%> (ø)
lib/core/services/upload.service.ts 85.35% <0.00%> (ø)
...rm/services/content-cloud-node-selector.service.ts 50.00% <0.00%> (-2.00%) ⬇️
...ontent-widget/attach-file-widget-dialog.service.ts 95.65% <0.00%> (-0.19%) ⬇️
...rocess/components/analytics-generator.component.ts 80.48% <50.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe95673...302c428. Read the comment docs.

@eromano
Copy link
Contributor

eromano commented Jun 18, 2020

I am merging it the test failing are not related to this PR

@eromano eromano merged commit e9350bd into develop Jun 18, 2020
@eromano eromano deleted the code-quality-fixes branch June 18, 2020 16:57
VitoAlbano pushed a commit that referenced this pull request Jun 19, 2020
* various code quality fixes

* reduce duplicated code

* add safety check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants