Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude failing test before the revert of the time modify is finalized #5794

Merged
merged 4 commits into from Jun 19, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Jun 18, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • [z] Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
exclude failing test before the revert of the time modify is finalized

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2020

Codecov Report

Merging #5794 into develop will decrease coverage by 1.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5794      +/-   ##
===========================================
- Coverage    85.64%   83.92%   -1.72%     
===========================================
  Files          517      955     +438     
  Lines        15355    26995   +11640     
  Branches      2043     3765    +1722     
===========================================
+ Hits         13151    22656    +9505     
- Misses        1574     3221    +1647     
- Partials       630     1118     +488     
Impacted Files Coverage Δ
...rm/services/content-cloud-node-selector.service.ts 50.00% <0.00%> (-2.00%) ⬇️
...lib/process/directives/cancel-process.directive.ts 75.00% <0.00%> (-0.68%) ⬇️
...c/lib/task-list/components/task-audit.directive.ts 90.00% <0.00%> (-0.48%) ⬇️
.../lib/task/directives/claim-task-cloud.directive.ts 91.17% <0.00%> (-0.26%) ⬇️
...-list/components/task-form/claim-task.directive.ts 92.85% <0.00%> (-0.25%) ⬇️
...ist/components/task-form/unclaim-task.directive.ts 92.85% <0.00%> (-0.25%) ⬇️
...ntent-node-selector/content-node-dialog.service.ts 84.14% <0.00%> (-0.20%) ⬇️
...ontent-widget/attach-file-widget-dialog.service.ts 95.65% <0.00%> (-0.19%) ⬇️
...ud/src/lib/form/components/form-cloud.component.ts 88.60% <0.00%> (-0.15%) ⬇️
...ib/process-services/src/lib/form/form.component.ts 89.38% <0.00%> (-0.12%) ⬇️
... and 446 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d71c0...040d5f7. Read the comment docs.

@eromano eromano merged commit 2a5fa95 into develop Jun 19, 2020
@eromano eromano deleted the dev-eromano-excludetest branch June 19, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants